pgChecks: Fix orioledb checks not running orioledb - #2484
Merged
Merged
Conversation
pkpkg.version is "orioledb-17" now (since f33c4f2) but the test script was still looking for `17_20` like patterns so never configured nor ran orioledb stuff for the orioledb packages. This simplifies things and is a better check since its a little looser, we want isOrioleDB not isOrioleDB17 after all. Also tweaked some of the pre-existing variables so they match the preffered form OrioleDB, orioleDB instead if necessary.
PostgreSQL Extension Dependency Analysis: PR #2484
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2484
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
cfunkhouser
approved these changes
Sep 24, 2026
cfunkhouser
left a comment
Contributor
There was a problem hiding this comment.
Stamping. Looks reasonably correct, modulo my inexperience with Nix.
Collaborator
Author
|
https://github.com/supabase/postgres/actions/runs/36014309265/job/107684566335#step:5:1267 shows what was missing when #2471 was merged, did not configure orioledb now it does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
OrioleDB extension isn't being configured/used in the pgtab, pg_regress tests since #2471.
What is the new behavior?
OrioleDB is enabled/configured for the tests, the code is also slightly easier to follow/grok now.