Repository navigation
keep filtered top-level tags out of SpecFilter output - #5355
Open
shamsManna wants to merge 1 commit into
Open
shamsManna wants to merge 1 commit into
shamsManna wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Two ways top-level tags that an
OpenAPISpecFiltermeant to hide still end up in the documentSpecFilter.filterreturns (and thatOpenApiResource/OpenApiServletserve):openAPI, not from the objectfilterOpenAPIreturned. A filter that drops a tag infilterOpenAPIgets the original list back. If the original had no tags but the filter added some, this throws an NPE.filterTopLevelTagsruns before the webhooks loop. Tags whose only operations are webhooks the filter removed are therefore never pruned. A tag used both by a hidden path operation and a kept webhook is dropped instead.Copied the tags from
filteredOpenAPIand moved the pruning after webhooks are processed. Added a regression test for each case. Both tests fail on master and pass with the fix.Type of Change
Checklist
Screenshots / Additional Context
./mvnw installpasses locally.