chore: bump version 2.5.0 - #1246
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: Cursor <cursoragent@cursor.com>
8cb5c7e to
eb77c89
Compare
There was a problem hiding this comment.
Release mechanics check out. No findings — safe to ship from my side.
Version: app/build.gradle.kts:189-190 → versionCode = 189, versionName = "2.5.0". Previous release (git cat-file -p "v2.4.1^{commit}:app/build.gradle.kts") was 188 / 2.4.1, so monotonic +1. I also checked the ABI-split logic, since the APK/AAB output code was restructured between 2.4.1 and 2.5.0 (applicationVariants.all → androidComponents.onVariants) — neither form applies an ABI offset to versionCode, both only rename output files, so the Play-uploaded AAB goes 188 → 189 with no regression.
Changelog consumption — all 36 fragments verified individually, not spot-checked:
- 36 fragments deleted (the 37th path is
.gitkeep, correctly retained), 36 bullets in the new section. 1:1. - Each fragment's exact text appears exactly once, under a heading matching its filename category. Zero dropped, zero duplicated, zero miscategorised. Category counts match filenames: added 11, changed 3, fixed 19, security 3.
- Issue-ID sets identical between fragment filenames and the
#NNNNsuffixes (sorteddiffis empty). - Released sections untouched — everything from
## [2.4.1]down is byte-identical apart from the link-reference block, which correctly repoints[Unreleased]and adds the[2.5.0]compare link. That's the expected mechanical output, not a manual edit. - No
changelog.d/hotfix/fragments swept in (that dir holds only.gitkeepat both base and head).
Stray changes: none. git diff --name-status is exactly M CHANGELOG.md, M app/build.gradle.kts, and 36 D changelog.d/next/*.md.
Semver: 2.5.0 is right. Even discounting the Paykit and dev-only entries, Trezor on-chain send (#1187), the Trezor Receive tab (#1189), hidden/passphrase Trezor wallets (#1142) and HW-name backup (#1173) are reachable new features, so a minor is justified rather than a patch.
* fix: vss client error recovery * fix: stop node before wiping keychain on reset * fix: harden wallet wipe and ldk vss client recovery * fix: wipe wallet in phases so reset never half-completes * fix: gate wipe on ldk storage and capture vss setup deferred * fix: stop a node object left alive by a failed start * fix: hold lifecycle lock across node stop and storage wipe * fix: fail reset when keychain wipe does not complete * fix: refuse node start during wipe and keep wallet on incomplete reset * fix: skip toast for node start refused during wipe
Co-authored-by: Cursor <cursoragent@cursor.com>
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
Resolve wipe/backup conflicts by keeping master additions (restorePendingUntil, lastKnownNodeId, migration cleanup). Co-authored-by: Cursor <cursoragent@cursor.com>
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
No blocker. The bump is clean and v2.5.0 is already tagged and published, so the shipped artifact is the tag, not this head. One advisory inline about code that came in via #1266, for a follow-up against master.
Checked and clean:
- Version.
versionCode = 190,versionName = "2.5.0", monotonic over 188. 189 was the first bump commit, superseded. No other file carries a version string. - Tag vs notes.
v2.5.0does not contain post-cut master, so the 2.5.0 section describes exactly what shipped. - Changelog. 36 fragments consumed into 36 bullets with matching issue ids, released sections untouched apart from the link block, and the 37 fragments still in
changelog.d/next/all arrived after the cut, so they belong to 2.6.0. Nothing dropped. The#1266bullet was hand-added rather than collected from a fragment; the result is right, but it bypassed the script. - Carry-over. The diff against master is only the changelog, the gradle bump and the deleted fragments.
- Cherry-pick.
81207664cand master's21c62aefadiffer only in hunk offsets. - No config drift. No secret, signing, endpoint or flavor change. I also diffed
v2.4.1..v2.5.0onapp/build.gradle.kts: theandroidComponents.onVariantsrestructure keeps every default, includingGEO=trueandFEATURE_PAYKIT_UI_DISABLED=false. No flag flipped on in this release.
![ovi-reviewer[bot]](https://avatars.githubusercontent.com/in/4862686?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: ✅ Approve
Reaudit: diff 2 files.
Counterpart synonymdev/bitkit-ios#740: equivalent.
Findings:
N/A
Audit:
Skipped - nothing a reviewer would report across 38 files (threshold 0.4; strongest changelog.d/next/1131.fixed.md at 0.10).
Replies:
piotr-iohk: Resolved conflicts, please review @ovitrif @jvsena42. (comment)
I checked the conflict resolution: CHANGELOG.md and app/build.gradle.kts match the v2.5.0 tag, and the rest of the net patch is unchanged since eb77c89.
Reviewed by claude-opus-5-5-xhigh via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest · audit (author or owner)
There was a problem hiding this comment.
ack - I trust reviewer bot on this, it does much more than I can do wrt. matching prs before and after merge / rebase / conflicts resolution
edit: scanned manually ✅
3 participants
Release 2.5.0.
Description
versionCodeto 189 andversionNameto 2.5.0changelog.d/next/intoCHANGELOG.mdunder[2.5.0] - 2026-09-10Design
N/A — no UI changes.
Preview
N/A
QA Notes
N/A — version bump and changelog only.