Repository navigation
Conversation
jvsena42
marked this pull request as ready for review
October 5, 2026 14:39
jvsena42
requested review from
a team,
ben-kaufman and
coreyphillips
and removed request for
a team
October 5, 2026 14:43
Contributor
|
Contributor
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
jvsena42
added this pull request to stack #1423
October 5, 2026 15:53
This was referenced Oct 5, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jvsena42
force-pushed
the
fix/paykit-auth-figma-parity
branch
from
October 6, 2026 12:13
a2e9569 to
18cbbec
Compare
1 task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1401.
This PR aligns the Paykit authorization sheet with the Auth (paykit) flow in Figma.
Description
app.paykit.server is requesting permission…) and removes the separateRequester IDline. The old sentence stays as the fallback when a request carries no client id.REQUESTED PERMISSIONS,DETAILSandBEFORE YOU CONTINUEheadings with 32dp between sections, removes the divider under the permissions, uses the Figma copy for the Paykit details and trust warning, and sets both to the 15sp body style.Out of Scope
strings.xml: the Figma title reads "Authorization Succesful"; the existing correctly spelled "Authorization Successful" is kept.Authorize paykit FaceIDframe: the Face ID prompt is the iOS system dialog; Android keeps its own biometric/PIN prompt.Type.kt: body styles keep the app-wide 0.4sp letter spacing where the frames show 0.bitkit-ios: ported in fix: align paykit auth sheet with figma bitkit-ios#880.Design
Preview
Pixel 9 emulator, dev build, combined
paykit-access-v1.watch-only-account-v1claim.QA Notes
Journeys
N/A — no journey added or updated. The route and test tags are unchanged, so
wallet-leg.xmlandpaykit-only-approval.xmlstill drive this sheet as written.Manual Tests
pubkyauth://signin_grantURL withcaps=/pub/paykit/:rw, acidandx-bitkit-claim=paykit-access-v1.watch-only-account-v1→ the Earn, Authorize, Authorizing and Success screens match the Figma frames above — needs a valid auth URL fixture.DETAILSsection — needs a valid auth URL fixture.Automated Checks
just compile,just test,just lint— pass locally.