Skip to content

fix: align paykit auth sheet with figma - #1421

Open
jvsena42 wants to merge 4 commits into
codex/paykit-shared-runtime-local-20260930from
fix/paykit-auth-figma-parity
Open

jvsena42 wants to merge 4 commits into
codex/paykit-shared-runtime-local-20260930from
fix/paykit-auth-figma-parity

Conversation

@jvsena42

@jvsena42 jvsena42 commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Stacked on #1401.

This PR aligns the Paykit authorization sheet with the Auth (paykit) flow in Figma.

Description

  • Earn consent: swaps the illustration for the three-coin stack the frame uses and draws it at the frame's scale, drops the extra 16dp side inset so the copy and buttons span the sheet width, and sets the gaps around the illustration to 32dp.
  • Authorize: names the requester in the lead sentence (app.paykit.server is requesting permission…) and removes the separate Requester ID line. The old sentence stays as the fallback when a request carries no client id.
  • Authorize: groups the content under REQUESTED PERMISSIONS, DETAILS and BEFORE YOU CONTINUE headings with 32dp between sections, removes the divider under the permissions, uses the Figma copy for the Paykit details and trust warning, and sets both to the 15sp body style.
  • Authorize: pins the trust warning and the profile card to the bottom of the sheet; the sections above scroll when they do not fit.
  • Profile card: replaces the centered 96dp avatar card with the compact row (48dp avatar, truncated key above the name). This applies to every Pubky auth dialog, as the design now uses it for all of them.
  • Authorizing: sets the label to the 15sp button text style and gives it the button's height so the content above no longer shifts when the buttons are replaced.
  • Success: names the requester in the summary sentence, insets the text 32dp from the sheet edges and draws the check illustration at the frame's scale.
  • Permission row: folder icon is 16dp and gains the duotone tab from the Figma icon.

Out of Scope

  • strings.xml: the Figma title reads "Authorization Succesful"; the existing correctly spelled "Authorization Successful" is kept.
  • Authorize paykit FaceID frame: the Face ID prompt is the iOS system dialog; Android keeps its own biometric/PIN prompt.
  • Type.kt: body styles keep the app-wide 0.4sp letter spacing where the frames show 0.
  • Translations: the new and changed strings are English only.
  • bitkit-ios: ported in fix: align paykit auth sheet with figma bitkit-ios#880.

Design

Preview

Pixel 9 emulator, dev build, combined paykit-access-v1.watch-only-account-v1 claim.

Screen Before / After / Figma
Earn consent Earn consent
Authorize Authorize
Authorizing Authorizing
Success Success

QA Notes

Journeys

N/A — no journey added or updated. The route and test tags are unchanged, so wallet-leg.xml and paykit-only-approval.xml still drive this sheet as written.

Manual Tests

  • Open a pubkyauth://signin_grant URL with caps=/pub/paykit/:rw, a cid and x-bitkit-claim=paykit-access-v1.watch-only-account-v1 → the Earn, Authorize, Authorizing and Success screens match the Figma frames above — needs a valid auth URL fixture.
  • Open a Pubky auth URL without a Bitkit claim → the Authorize screen shows the compact profile card and no DETAILS section — needs a valid auth URL fixture.

Automated Checks

  • ran just compile, just test, just lint — pass locally.

@jvsena42 jvsena42 changed the title fix/paykit auth figma parity fix: align paykit auth sheet with figma Oct 5, 2026
@jvsena42 jvsena42 self-assigned this Oct 5, 2026
@jvsena42
jvsena42 marked this pull request as ready for review October 5, 2026 14:39
@jvsena42
jvsena42 requested review from a team, ben-kaufman and coreyphillips and removed request for a team October 5, 2026 14:43
@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Updates the authorization approval sheet UI.

The PR appears safe to merge, with non-blocking feedback about keeping consent readable in short windows.

Findings

  1. P2 Footer crowds out consent ▶

Summary

Updates the Pubky authorization sheet to match the Paykit design.

  • Adds requester names, section headings, compact profile cards, and revised illustrations.
  • Keeps the warning and identity card below the scrolling details.
  • Non-blocking feedback: provide a short-window fallback for the fixed footer.

jvsena42 explicitly deferred translations, app-wide letter-spacing changes, the iOS biometric dialog, and the matching iOS implementation. jvsena42 intentionally retained the correctly spelled success title.

Reviews (1) · Last reviewed commit: "chore: add auth sheet changelog fragment"

Comment thread app/src/main/java/to/bitkit/ui/screens/profile/PubkyAuthApprovalSheet.kt Outdated
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 18cbbec (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

jvsena42 and others added 4 commits October 6, 2026 09:09
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant