Skip to content

feat: start the vss server for wallet backup tests - #17

Merged
ovitrif merged 3 commits into
mainfrom
feat/vss-server-for-wallet-backups
Oct 7, 2026
Merged

ovitrif merged 3 commits into
mainfrom
feat/vss-server-for-wallet-backups

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Description

  • A vss compose profile starts the VSS server and its own database on port 5050 for wallet backup tests. The image builds on Debian bookworm.
  • The review stack's test environment runs this change; the test run that needs it is reported in a comment here.
  • Checked: The server answers GET /vss/getObject with HTTP 401 when no token is sent, and the lane check lists bitkit-docker:vss.

Out of Scope

  • None.

The vss profile starts the pinned server and its own database on
127.0.0.1:5050, without the lnurl auth server or the rest of the stack.
Bullseye's security archive no longer serves the packages the image installs.
@ovitrif ovitrif self-assigned this Oct 5, 2026

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: 👍 Approve

The test run on synonymdev/bitkit-android#1401 at head 98a1570 ran item 5, the one that needed the VSS server, on the environment built from commit d187ba3 of this change, and it passed.

Every item of the run that needed the change ran on it and passed, so the VSS server and its database started and served the wallet backup test as intended.

@ovitrif
ovitrif marked this pull request as ready for review October 6, 2026 02:13
@ovitrif

ovitrif commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Validation: passes at 69d5ede. Ready to merge.

This PR conflicted with main in CHANGELOG.md only. I merged main in 69d5ede, keeping both changelog lines, and GitHub now reports it mergeable.

CI: the repository runs no checks on pull requests.

Local checks on 69d5ede:

  • docker compose config resolves with no profile and with every profile.

Bring-up:

  • I built the vss image from vss/Dockerfile with the pinned vss-server submodule (14d4b4f), on Debian bookworm, in 3 min 10 s.
  • I started vss-postgres and vss in a Compose project of their own (Docker 29.4, arm64).
  • vss-postgres turns healthy, and the server applies migrations 0 through 3 and listens on 5050.

Real calls:

  • POST /vss/getObject without a token: 401.
  • The repository's vss-test (vss_jwt_test):
    • listKeyVersions with an RS256 token signed by lnurl-server/keys/private.pem: 200.
    • The same call with a token from another key: 401.
    • Result: 2 passed, 0 failed.

The default stack's vss-server image no longer builds (vss-server/rust/Dockerfile installs libssl1.1, which the current Debian base does not ship). This profile's image is the one that builds.

@ovitrif
ovitrif merged commit 5ac4855 into main Oct 7, 2026
@ovitrif
ovitrif deleted the feat/vss-server-for-wallet-backups branch October 7, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant