Conversation
Draft
1 task done
ovitrif
force-pushed
the
feat/allowance-auto-accept
branch
from
October 1, 2026 21:52
b0c583e to
80f5c0f
Compare
Collaborator
Author
|
Pushed 0b8e352: this PR now sits on the updated #799 (merge 8f0449c, Paykit SDK rc59 with identity-wide shared state).
|
Collaborator
Author
|
Pushed 14307a0: merged the updated #799 (a19ea87: the request-presentation and covered-request fixes and more of Ben's shared-runtime merges) into this PR; the merge was clean and nothing in the auto-accept code changed. Local verification: the Paykit and allowance suites on an iPhone 17 simulator, 382 tests, 0 failures. |
jvsena42
added this pull request to stack #866
October 2, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #807
Twin: synonymdev/bitkit-android#1385
Stacked on #799
Refs: #805
This PR makes the allowee's wallet accept an allowance the allower offers, so the allowee taps nothing and the allowance is active as soon as the offer arrives.
Description
Out of Scope
Design
N/A — no design available.
Preview
07-side-by-side-payer-left-payee-right.mp4
QA Notes
Journeys
set-and-accept.xmlManual Tests
regression:payee: allowance detail → Swipe To End Allowance: ends on both sides.PaykitAllowanceExecutorTests.swift.Automated Checks
PaykitAllowanceTests.swift— only a received proposal from the allower counts as an offerPaykitAllowanceExecutorTests.swift— an allower's offer is accepted without the sheet and not announced twice; an allowee's ask still goes to the sheet; sent and answered proposals are never acceptedxcodebuild test -only-testing:BitkitTestson an iPhone 17 simulator (iOS 26.5) with Paykit rc59 — 1,625 tests, 12 skipped, 0 failuresset-and-accept.xmlon two simulators against the staging regtest backend: the payee turned Active with no tap about 95 s after the proposal arrived, no review sheet opened, and the toast "Allowance Added" showed (the system notification was not exercised, no permission prompt appeared)