Conversation
Swipe to pay on the send confirmation stays disabled and shows its loading state while an on-chain payment has no fee rate yet. submitPayment also resolves a missing fee rate before anything is consumed, so an automatic payment never starts without one.
Collaborator
Author
|
Pushed 9be9583: renamed the changelog fragment to this PR's number, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #775
This PR keeps Swipe To Pay disabled until the fee rate has loaded.
Description
Out of Scope
Bitkit/Views/Wallets/Send/SendSheet.swift: the fee-rate fetch itself (its timeout, error logging and when it runs) is unchanged; if the fetch fails for good the swipe stays disabled until the funding source is switched or the sheet is reopened.Design
N/A — no design available. The swipe reuses its existing disabled and loading states.
Preview
QA Notes
Journeys
N/A — not drivable; see Manual Tests.
Manual Tests
regression:Lightning invoice → Send confirmation → the swipe is enabled immediately, without waiting for the fee rate — network throttling not in CapabilitiesAutomated Checks
SendConfirmationSwipeTests.swift— on-chain payment without a fee rate disables the swipe, and it enables once a rate is setSendConfirmationSwipeTests.swift— Lightning and hardware payments never wait on the wallet fee rate