Repository navigation
docs: point the lnurl journey at the fixture's new host port - #889
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Updates the LNURL journey README to read the lnurl-pay fixture on 127.0.0.1:23010. Reviewed 4f34d7f, light tier.
What I checked, and 1 candidate I ruled out
Read in full: journeys/lnurl/README.md
Cross-repo contract: bitkit-docker#19 (merged) moves the fixture to host port 23010 (container 3010).
CI: validate green; Run Tests and Run Integration Tests still pending at review time. A docs-only change cannot affect them.
Ruled out
- Other references to
3010: none left anywhere in the repo.
Merge confidence: 5/5, a docs-only change matching the merged fixture port.
jvsena42
left a comment
There was a problem hiding this comment.
No findings at 4f34d7f.
Checked:
- All three
3010occurrences injourneys/lnurl/README.mdare replaced; nothing else in the repo names that port at head. - 23010 matches the fixture published port after synonymdev/bitkit-docker#19 (
23010:3010), and the endpoints, profile and service name the README uses (/generate/pay,POST /fixture,--profile lnurl-pay,lnurl-server-fixture) match its compose file. - No doc, journey, xcconfig or workflow names any other port that change moved. The Android side (synonymdev/bitkit-android#1438) covers 23735 / 23000 in tooling and has no lnurl README to disagree with.
Commands were not executed against a running stack. Device gate: no device check needed (docs only).
jvsena42
left a comment
There was a problem hiding this comment.
No findings at 4f34d7f.
Checked:
- All three
3010occurrences injourneys/lnurl/README.mdare replaced; nothing else in the repo names that port at head. - 23010 matches the fixture published port after synonymdev/bitkit-docker#19 (
23010:3010), and the endpoints, profile and service name the README uses (/generate/pay,POST /fixture,--profile lnurl-pay,lnurl-server-fixture) match its compose file. - No doc, journey, xcconfig or workflow names any other port that change moved. The Android side (synonymdev/bitkit-android#1438) covers 23735 / 23000 in tooling and has no lnurl README to disagree with.
Commands were not executed against a running stack. Device gate: no device check needed (docs only).
Refs: synonymdev/bitkit-docker#19
Description
lnurl-payfixture on127.0.0.1:23010, the host port bitkit-docker#19 moves it to from3010.Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Journeys
N/A
Manual Tests
N/A
Automated Checks
N/A