Skip to content

docs: point the lnurl journey at the fixture's new host port - #889

Merged
ovitrif merged 1 commit into
masterfrom
docs/lnurl-fixture-host-port
Oct 9, 2026
Merged

ovitrif merged 1 commit into
masterfrom
docs/lnurl-fixture-host-port

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Refs: synonymdev/bitkit-docker#19

Description

  • The LNURL journey README reads the lnurl-pay fixture on 127.0.0.1:23010, the host port bitkit-docker#19 moves it to from 3010.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif self-assigned this Oct 7, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T23:46:34.487609Z 4f34d7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Updates documentation for a test fixture port number.

This documentation-only change appears safe to merge.

Summary

Updates the LNURL journey setup guide to use host port 23010 instead of 3010.

  • Changes both the link-fetching command and the command that switches the fixture mode.
  • No actionable issues were found.

Reviews (1) · Last reviewed commit: "docs: point the lnurl journey at the fix..." · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Updates the LNURL journey README to read the lnurl-pay fixture on 127.0.0.1:23010. Reviewed 4f34d7f, light tier.

What I checked, and 1 candidate I ruled out

Read in full: journeys/lnurl/README.md
Cross-repo contract: bitkit-docker#19 (merged) moves the fixture to host port 23010 (container 3010).
CI: validate green; Run Tests and Run Integration Tests still pending at review time. A docs-only change cannot affect them.

Ruled out

  • Other references to 3010: none left anywhere in the repo.

Merge confidence: 5/5, a docs-only change matching the merged fixture port.

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings at 4f34d7f.

Checked:

  • All three 3010 occurrences in journeys/lnurl/README.md are replaced; nothing else in the repo names that port at head.
  • 23010 matches the fixture published port after synonymdev/bitkit-docker#19 (23010:3010), and the endpoints, profile and service name the README uses (/generate/pay, POST /fixture, --profile lnurl-pay, lnurl-server-fixture) match its compose file.
  • No doc, journey, xcconfig or workflow names any other port that change moved. The Android side (synonymdev/bitkit-android#1438) covers 23735 / 23000 in tooling and has no lnurl README to disagree with.

Commands were not executed against a running stack. Device gate: no device check needed (docs only).

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings at 4f34d7f.

Checked:

  • All three 3010 occurrences in journeys/lnurl/README.md are replaced; nothing else in the repo names that port at head.
  • 23010 matches the fixture published port after synonymdev/bitkit-docker#19 (23010:3010), and the endpoints, profile and service name the README uses (/generate/pay, POST /fixture, --profile lnurl-pay, lnurl-server-fixture) match its compose file.
  • No doc, journey, xcconfig or workflow names any other port that change moved. The Android side (synonymdev/bitkit-android#1438) covers 23735 / 23000 in tooling and has no lnurl README to disagree with.

Commands were not executed against a running stack. Device gate: no device check needed (docs only).

@ovitrif
ovitrif merged commit 714ac66 into master Oct 9, 2026
18 checks passed
@ovitrif
ovitrif deleted the docs/lnurl-fixture-host-port branch October 9, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants