Repository navigation
ci: verify XCFramework is complete in npm package - #63
Merged
Merged
Conversation
Every file sealed in TalsecRuntime.xcframework's _CodeSignature must be published, otherwise Xcode fails signature collection when archiving. Dot-files such as .jbroot/libRHProbe.dat are excluded by default and only ship thanks to the negation in .npmignore, so guard it in CI by diffing the npm package file list against the tracked XCFramework files. Ref talsec/Free-RASP-Cordova#77 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Adds a
verify-npm-packageCI job that diffs the files the npm package would publish againstgit ls-files ios/Plugin/TalsecRuntime.xcframework.Every file sealed in the XCFramework's
_CodeSignature/CodeResourcesmust ship, otherwise Xcode fails on archive withsignature-collection failed … A sealed resource is missing or invalid..jbroot/libRHProbe.datis a dot-file, so it only ships because of the negation rule in.npmignore. This repo is correct today; the job keeps it that way. Cordova shipped without it in 9.1.3 (talsec/Free-RASP-Cordova#77).File list source:
npm pack --dry-run --json.Verification (from
main)Ran the job's
run:script locally withbash -eo pipefail:.npmignore: pass.npmignore: fail, reporting both missing.jbroot/libRHProbe.datfilesNo package or version changes.
Resolved issues
Ref talsec/Free-RASP-Cordova#77
🤖 Generated with Claude Code