Skip to content

[release-v0.45.x] fix: use latest Tekton releases and fix ConfigMap timing - #3323

Merged
tekton-robot merged 1 commit into
tektoncd:release-v0.45.xfrom
divyansh42:cherry-pick-3298-to-release-v0.45.x
Oct 6, 2026
Merged

tekton-robot merged 1 commit into
tektoncd:release-v0.45.xfrom
divyansh42:cherry-pick-3298-to-release-v0.45.x

Conversation

@divyansh42

Copy link
Copy Markdown
Member

Changes

Cherry-pick of #3298 onto release-v0.45.x.

Update E2E test setup to fix the ConfigMap timing issue:

Triggers:

  • Skip nightly builds (currently broken) and use latest release directly
  • Fix timing issue: Wait for pods AFTER applying interceptors.yaml (not before)

Pipelines:

  • Simplify to use latest release directly (this branch already resolved to pipeline/latest via a nightly-fallback path; this just drops the now-unneeded nightly attempt, matching main).

Root Cause

Triggers v0.37.1 added a new ConfigMap config-triggers-core-interceptors for the GitHub Enterprise host allowlist feature. The triggers controller fatally crashes on startup if this ConfigMap doesn't exist, even though the feature defaults to disabled:

{"severity":"fatal","message":"Failed to start configmap watcher","error":"configmap "config-triggers-core-interceptors" not found"}

The ConfigMap is included in interceptors.yaml, but the installation order was broken: pods were waited on before interceptors.yaml was applied, so the controller crashed before the ConfigMap existed.

Fix

Move wait_until_pods_running to AFTER applying interceptors.yaml, matching the installation pattern used by tektoncd/triggers itself.

Submitter Checklist

  • Includes tests (if functionality changed/added) — N/A, test infrastructure change only
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated — N/A, no code changes
  • Commit messages follow commit message best practices

Release Notes

NONE

Update E2E test setup to use latest stable releases and fix ConfigMap timing issue:

**Pipelines:**
- Remove v1.12.0 pin and use latest release
- Remove TODO comment about switching back to latest

**Triggers:**
- Skip nightly builds and use latest release directly
- Fix timing: wait for pods AFTER applying interceptors (not before)

**Root Cause:**
Triggers v0.37.1 added config-triggers-core-interceptors ConfigMap for GitHub Enterprise allowlist feature. The controller fatally crashes on startup if this ConfigMap doesn't exist, even though the feature defaults to disabled.

Old broken order caused controller to crash:
1. Apply release.yaml (creates controller Deployment)
2. **Wait for pods** (controller starts, needs ConfigMap, crashes)
3. Apply interceptors.yaml (ConfigMap created too late)

**Fix (matching tektoncd/triggers pattern):**
1. Apply release.yaml (creates CRDs and Deployment)
2. Wait for ClusterInterceptor CRD to be Established (provides delay for image pull)
3. Apply interceptors.yaml (creates ConfigMap before controller starts)
4. Wait for pods (controller finds ConfigMap, starts successfully)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
(cherry picked from commit bb65fb6)
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 5, 2026
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2026
@divyansh42

Copy link
Copy Markdown
Member Author

/retest

@pratap0007

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2026
@tekton-robot
tekton-robot merged commit 1568d9e into tektoncd:release-v0.45.x Oct 6, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants