Repository navigation
[release-v0.45.x] fix: use latest Tekton releases and fix ConfigMap timing - #3323
Merged
tekton-robot merged 1 commit intoOct 6, 2026
Conversation
Update E2E test setup to use latest stable releases and fix ConfigMap timing issue: **Pipelines:** - Remove v1.12.0 pin and use latest release - Remove TODO comment about switching back to latest **Triggers:** - Skip nightly builds and use latest release directly - Fix timing: wait for pods AFTER applying interceptors (not before) **Root Cause:** Triggers v0.37.1 added config-triggers-core-interceptors ConfigMap for GitHub Enterprise allowlist feature. The controller fatally crashes on startup if this ConfigMap doesn't exist, even though the feature defaults to disabled. Old broken order caused controller to crash: 1. Apply release.yaml (creates controller Deployment) 2. **Wait for pods** (controller starts, needs ConfigMap, crashes) 3. Apply interceptors.yaml (ConfigMap created too late) **Fix (matching tektoncd/triggers pattern):** 1. Apply release.yaml (creates CRDs and Deployment) 2. Wait for ClusterInterceptor CRD to be Established (provides delay for image pull) 3. Apply interceptors.yaml (creates ConfigMap before controller starts) 4. Wait for pods (controller finds ConfigMap, starts successfully) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> (cherry picked from commit bb65fb6)
Member
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick of #3298 onto
release-v0.45.x.Update E2E test setup to fix the ConfigMap timing issue:
Triggers:
Pipelines:
Root Cause
Triggers v0.37.1 added a new ConfigMap config-triggers-core-interceptors for the GitHub Enterprise host allowlist feature. The triggers controller fatally crashes on startup if this ConfigMap doesn't exist, even though the feature defaults to disabled:
{"severity":"fatal","message":"Failed to start configmap watcher","error":"configmap "config-triggers-core-interceptors" not found"}
The ConfigMap is included in interceptors.yaml, but the installation order was broken: pods were waited on before interceptors.yaml was applied, so the controller crashed before the ConfigMap existed.
Fix
Move wait_until_pods_running to AFTER applying interceptors.yaml, matching the installation pattern used by tektoncd/triggers itself.
Submitter Checklist
make checkmake generated— N/A, no code changesRelease Notes