Report subtests through the exception handlers - #633
Merged
Merged
Conversation
Subtest failures were buffered on the test case and replayed at the end of RunTest._run_core, bypassing testtools' own exception machinery. That lost several behaviours relative to a non-subtest failure: - a subclass overriding `skipException` had its skip reported as an error, since `subTest` caught the hardcoded `unittest.SkipTest` - `expectFailure` inside a subtest leaked the private `_ExpectedFailure` as an error instead of recording an expected failure - `MultipleExceptions` was reported verbatim rather than unpacked - details attached inside a failing subtest never reached the result - `AsynchronousDeferredRunTest._run_core` never drained the buffers, so a failing subtest reported as a pass Report each subtest as it completes instead, dispatching on the case's exception handlers and passing the details accumulated inside the block. Since reporting no longer lives in `_run_core`, the Twisted runner is covered too; it only needs to know not to also report success. Also align with unittest where the buffering had diverged. Follow-up to #630.
jelmer
enabled auto-merge
September 14, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtest failures were buffered on the test case and replayed at the end of RunTest._run_core, bypassing testtools' own exception machinery. That lost several behaviours relative to a non-subtest failure:
skipExceptionhad its skip reported as an error, sincesubTestcaught the hardcodedunittest.SkipTestexpectFailureinside a subtest leaked the private_ExpectedFailureas an error instead of recording an expected failureMultipleExceptionswas reported verbatim rather than unpackedAsynchronousDeferredRunTest._run_corenever drained the buffers, so a failing subtest reported as a passReport each subtest as it completes instead, dispatching on the case's exception handlers and passing the details accumulated inside the block. Since reporting no longer lives in
_run_core, the Twisted runner is covered too; it only needs to know not to also report success.Also align with unittest where the buffering had diverged.
Follow-up to #630.