Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-walls-click.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"flowbite-react": patch
---

fix(navbar): keep the mobile navbar open when a nested interactive element is clicked
21 changes: 21 additions & 0 deletions packages/ui/src/components/Navbar/Navbar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,27 @@ describe("Navbar", () => {
});

describe("Interactions", () => {
it("should keep the collapse open when clicking a nested interactive element", async () => {
const user = userEvent.setup();
render(
<Navbar>
<NavbarToggle />
<NavbarCollapse>
<NavbarLink as="span">
<button type="button">Open menu</button>
</NavbarLink>
</NavbarCollapse>
</Navbar>,
);

const collapse = screen.getByTestId("flowbite-navbar-collapse");
await user.click(screen.getByTestId("flowbite-navbar-toggle"));
expect(collapse).not.toHaveClass("hidden");

await user.click(screen.getByRole("button", { name: "Open menu" }));
expect(collapse).not.toHaveClass("hidden");
});

it("should hide/show `NavbarMenu` when toggle is clicked", async () => {
const user = userEvent.setup();
render(<NavbarTest />);
Expand Down
8 changes: 8 additions & 0 deletions packages/ui/src/components/Navbar/NavbarLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ export const NavbarLink = forwardRef<HTMLLIElement, NavbarLinkProps>((props, ref
} = resolveProps(props, provider.props?.navbarLink);

function handleClick(event: MouseEvent<HTMLAnchorElement>) {
const target = event.target as Element;
const interactiveTarget = target.closest("a, button, input, select, textarea, [role=\"button\"]");

if (interactiveTarget && interactiveTarget !== event.currentTarget) {
onClick?.(event);
return;
}

setIsOpen(false);
onClick?.(event);
}
Expand Down
Loading