Repository navigation
chore: Test that writing an event keeps its trace context. - #414
Merged
Merged
Conversation
The client already sends the trace context of an event as traceparent and tracestate, the names the server expects. No test wrote an event with a trace context, though, so sending other names, as the Go client did, would have gone unnoticed. The new test writes an event with a trace context, and checks it on the written event and on the event read back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client already sends the trace context of an event as
traceparentandtracestate, the names the server expects. So far, though, no test wrote an event with a trace context. The Go client senttraceParentandtraceState, which the server rejects, and nothing noticed it (fixed in thenativeweb/eventsourcingdb-client-golang#191).What changes:
traceparentandtracestate, and checks both on the written event and on the event read back.Tests: With the keys sent as
traceParentandtraceState, the new test fails, since the server answers with400. With the client as it is,npm run qa(75 tests) and the build are green.🤖 Generated with Claude Code
https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz