ASoC: soc-acpi-intel-arl-match: add rt712 on link 0 config - #5901
ASoC: soc-acpi-intel-arl-match: add rt712 on link 0 config#5901bardliao wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an additional SoundWire machine match for Arrow Lake (ARL) platforms to support an RT712-only configuration intended to work with PCH DMIC capture.
Changes:
- Introduces a new endpoint set and ADR device description for an RT712 configuration without the existing “group1 + dmic” endpoint aggregation.
- Adds a new SoundWire link description for link0 containing only RT712.
- Extends the ARL SoundWire machine table with a new match entry for the RT712 (VB quirk) + link0-only case.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The new link0-only RT712 machine entry may incorrectly match RT712 variant hardware (e.g., RT712-VB) without a variant-specific guard, risking selection of an incompatible endpoint/topology configuration.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
The new amp endpoint aggregation settings and the use of a “dummy” topology filename can change dailink grouping and can make the system fail to load any topology if function fragments are not present.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
sound/soc/intel/common/soc-acpi-intel-arl-match.c:632
- Using a topology filename containing "dummy" disables fallback to a monolithic topology: snd_sof_load_topology() treats it as "function topology required" and returns -EINVAL if get_function_tplg_files yields 0 fragments (sound/soc/sof/topology.c:2525-2560). Please ensure the required function topology fragments are guaranteed available for this ARL+RT712 configuration, or use a non-dummy monolithic topology name to allow fallback when fragments are missing.
.link_mask = BIT(0),
.links = arl_rt712_l0,
.drv_name = "sof_sdw",
.sof_tplg_filename = "sof-arl-dummy.tplg",
.get_function_tplg_files = sof_sdw_get_tplg_files,
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Add rt712 on link 0 configuration on ARL platform. Export all supported endpoints and the endpoint will be skipped if it is not listed in the SDCA DisCo table. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Tested-by: Patrick Daether <daether@pd-digital.de>
There was a problem hiding this comment.
🟡 Changes recommended
The new machine entry and PR description reference “PCH DMIC”, but the change does not appear to include the required mechanism (e.g., SOC_SDW_PCH_DMIC quirk/dmic_num) to actually enable PCH DMIC link/topology selection.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
| { | ||
| .link_mask = BIT(0), | ||
| .links = arl_rt712_l0, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-arl-dummy.tplg", | ||
| .get_function_tplg_files = sof_sdw_get_tplg_files, | ||
| }, |
| .links = arl_rt712_l0, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-arl-dummy.tplg", | ||
| .get_function_tplg_files = sof_sdw_get_tplg_files, |
bardliao
changed the title
Add rt712 on link 0 configuration on ARL platform. Export all supported
endpoints and the endpoint will be skipped if it is not listed in the
SDCA DisCo table.