feat(riscv): add module to reduce code duplicates between rv32 and rv64 - #708
Open
romancardenas wants to merge 1 commit into
Open
romancardenas wants to merge 1 commit into
romancardenas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While navigating through awkernel's source code, I noticed that there are a lot of duplicates between rv32 and rv64 targets.
This PR includes a
rv_commonmodule that will encapsulate all the common logic between rv32 and rv64 targets. I started with the implementation of theInterrupttrait, as it was a fairly simple modification.Let me know if you like this structure. If so, I will keep porting the common logic gradually so PR reviews are bearable.
How was this PR tested?
The project compiles for both rv64 and rv32 backends. As no console is available, it is difficult to verify the correct behavior yet.
Notes for reviewers
I also used the
riscvdependency for reducing the inline assembly code. This crate contains a lot of register access bindings etc., and is developed under the umbrella of Rust's embedded working group. I thought it would be a good practice to use it when possible.