fix: flaky auth in e2e test - #130
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe Playwright authentication setup now checks username focus and verifies the entered ChangesAuthentication setup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The authentication setup now waits for the delayed login-page focus behavior before entering credentials and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit reads each line, Comment |
Fixes the occasional failure on an end-2-end test at login.
Background
Occasionally, I encountered a end-2-end test that failed on the login page where the password was on the username. There is a function that runs after 100ms of loading the login page (https://github.com/WordPress/WordPress/blob/master/wp-login.php#L1624). Playwright went on and filled the password into the username failed because the function triggered right when playwright was entering the password. This happened once in every 100 runs, but it was annoying nonetheless.
Summary by CodeRabbit