Repository navigation
compiler: avoid byte slice copies in mixed string comparisons - #5784
Open
davecheney wants to merge 1 commit into
Open
davecheney wants to merge 1 commit into
davecheney wants to merge 1 commit into
Conversation
Member
|
From a corrrectness standpoint the test corpus is happy with this change, but we should figure out what's happening with the AVR build (and also the binary size test failed CI). |
davecheney
force-pushed
the
davecheney-mixed-string-comparisons
branch
from
September 30, 2026 09:25
c535c5d to
26cbd22
Compare
Contributor
Author
The AVR build needs an exception, like math.go, because after inlining main.main is large enough it needs more stack than simavr provides. |
davecheney
force-pushed
the
davecheney-mixed-string-comparisons
branch
from
October 13, 2026 13:00
26cbd22 to
ce70b56
Compare
davecheney
marked this pull request as ready for review
October 14, 2026 10:15
davecheney
force-pushed
the
davecheney-mixed-string-comparisons
branch
from
October 14, 2026 10:17
18a32c9 to
2019822
Compare
davecheney
force-pushed
the
davecheney-mixed-string-comparisons
branch
from
October 14, 2026 14:59
2019822 to
510413c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.