Skip to content

transform, interp: remove test fixture cache workaround - #5871

Merged
deadprogram merged 1 commit into
tinygo-org:devfrom
davecheney:dfc/go-llvm-stat-fixtures
Oct 14, 2026
Merged

deadprogram merged 1 commit into
tinygo-org:devfrom
davecheney:dfc/go-llvm-stat-fixtures

Conversation

@davecheney

@davecheney davecheney commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Update go-llvm to 0f603bc. NewMemoryBufferFromFile now stats the file before it opens it, so go test tracks the LLVM test fixtures as cache inputs. Thus the ensureTestCacheFreshness helper is no longer necessary.

Fixes #5780

@davecheney
davecheney force-pushed the dfc/go-llvm-stat-fixtures branch from ac1a12c to 121dcbd Compare October 13, 2026 12:48

@dgryski dgryski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram

Copy link
Copy Markdown
Member

@davecheney please resolve merge conflict. Thank you.

Update go-llvm to 84377ab. NewMemoryBufferFromFile now stats the file before it opens it, so go test tracks the LLVM test fixtures as cache inputs. Thus the ensureTestCacheFreshness helper is not necessary. This update also adds the Arch Linux LLVM search paths from tinygo-org/go-llvm#84.

Fixes tinygo-org#5780
@davecheney
davecheney force-pushed the dfc/go-llvm-stat-fixtures branch from 121dcbd to 5f70f72 Compare October 14, 2026 10:02
@davecheney

Copy link
Copy Markdown
Contributor Author

@deadprogram done, PTAL

@deadprogram

Copy link
Copy Markdown
Member

Thanks @davecheney and to @dgryski for review. Now merging.

@deadprogram
deadprogram merged commit cb01520 into tinygo-org:dev Oct 14, 2026
33 checks passed
@davecheney
davecheney deleted the dfc/go-llvm-stat-fixtures branch October 14, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go test caching does not track .ll fixtures loaded through go-llvm

3 participants