Repository navigation
fix: DecimalField no longer raises InvalidOperation for values over 28 digits - #2349
Merged
waketzheng merged 6 commits intoOct 19, 2026
Merged
Conversation
Merging this PR will not alter performance
|
waketzheng
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DecimalField.to_python_valuequantized with the active decimal context, whose default precision is 28 significant digits. A value with more digits than that (for example amax_digits=40field) raiseddecimal.InvalidOperation. The quantize now runs in a copy of the active context with its precision raised to at leastmax_digits, so the caller's rounding mode and traps are kept and values that really exceedmax_digitsstill raise.Motivation and Context
Fixes #2347
How Has This Been Tested?
TORTOISE_TEST_DB=sqlite://:memory: .venv/bin/python -m pytest tests/fields/test_decimal.py(26 passed)ruff format --checkandruff check(0.15.9) on the changed files,codespellandmypy tortoise/fields/data.py tests/fields/test_decimal.pyall pass.Checklist: