Repository navigation
馃悰 fix(subprocess): stop hanging on undecodable backend output - #311
Merged
gaborbernat merged 3 commits intoOct 7, 2026
Merged
Conversation
gaborbernat
enabled auto-merge (squash)
October 7, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A build backend, or a compiler it runs, can write bytes that the frontend's locale encoding cannot decode.
Popen.communicate()decodes the captured output after the child exits, so it raisesUnicodeDecodeErrorinside the output collection thread. Since #282 the frontend waits for that thread to store the output before it reads the backend result, so one bad byte leaves the frontend polling forever. 馃悰 Before that change the same input crashed with aTypeError.The frontend now decodes the backend's stdout and stderr with
errors="backslashreplace". Those streams carry diagnostics; the backend result travels through a separate JSON file, so the lossy decode cannot touch it. Backslash escapes keep the original byte visible asbefore\xffafter, wherereplacewould show aU+FFFDplaceholder and hide which byte broke the log. 馃攳The request sent over stdin is ASCII JSON, so the error handler changes nothing on the encode side. An exception other than a decode error inside the output collection thread still hangs the frontend; this PR fixes the decode case.