Skip to content

[Suggestion] add a variables file, allow modifying the variables used in the scss files #51

Open

Description

@WilliamStam

im not a fan of the forcing of using secondary for many of the label colours etc. wouldnt it be better if you included a _variables.scss file similar to how bootstrap does it with !default? that way we can override the defaults with say $select2-theme-bootstrap4-secondary: $gray;

$select2-theme-bootstrap4-input-bg: $input-bg !default;
$select2-theme-bootstrap4-input-border-radius: $input-border-radius !default;
$select2-theme-bootstrap4-input-box-shadow: $input-box-shadow !default;
$select2-theme-bootstrap4-input-transition: $input-transition !default;
$select2-theme-bootstrap4-input-focus-border-color: $input-focus-border-color !default;
$select2-theme-bootstrap4-input-focus-box-shadow: $input-focus-box-shadow !default;
$select2-theme-bootstrap4-input-disabled-bg: $input-disabled-bg !default;


$select2-theme-bootstrap4-secondary: $secondary !default;

should be as easy as finding $ and then just prefixing them with a prefix and setting up a _variables.scss file

Activity

  1. rodrigo-arias commented on Nov 4, 2020

    @rodrigo-arias

    Totally in favor of this approach

  2. tagliala commented on Mar 3, 2021

    @tagliala
    Contributor

    I would like to do this in #67

  3. added 4 commits that reference this issue on Mar 3, 2021
    88f0800
    fa7445d
    dfba182
    7147416
  4. added 4 commits that reference this issue on Mar 13, 2021
    fc0e9a1
    7d12a3e
    28a61b6
    954b920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions