Skip to content

chore(docker): supply docker compose via Bazel - #830

Open
mnoah1 wants to merge 2 commits into
mainfrom
mnoah1/pin-docker-compose
Open

mnoah1 wants to merge 2 commits into
mainfrom
mnoah1/pin-docker-compose

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Host-installed Compose versions can reject flags such as up --wait, breaking local stacks and Docker tests.

What?

  • Use rules_docker_compose 0.4.0 and its default Compose 5.5.1 directly from Bazel and test runfiles. Upgrade both through MODULE.bazel.
  • Upgrade rules_go to 0.59.0 and Gazelle to 0.53.0; keep Go 1.25.0.
  • Make service Dockerfiles work without Buildx. Docker CLI and a reachable daemon remain required.

Test Plan

Build, 134 unit targets, 13 Docker integration/e2e targets, documentation, lint, Gazelle, tidy, and mock checks passed. Verified startup, a demo request reaching landed, and shutdown without Buildx or a host Compose plugin.

Unit checks used isolated Git configuration and pinned helpers. Live GitHub cases skipped without credentials. The shared verifier could not complete coverage/lint checks; repository checks passed.

To try locally:

./tool/bazel run @rules_docker_compose//docker_compose -- version
make local-submitqueue-start
make demo-requests COUNT=1 WATCH=true BURST=true
make local-submitqueue-stop

Revert Plan

Revert this PR to restore host-selected Compose and previous build-rule versions.

@mnoah1
mnoah1 force-pushed the mnoah1/pin-docker-compose branch from a70880b to fee529a Compare October 9, 2026 18:00
Use pinned rules_docker_compose 0.4.0 and its default Compose 5.5.1 for local stacks and Docker tests. Ruleset upgrades select the new release's default CLI without a separate version override. Upgrade rules_go to 0.59.0 and Gazelle to 0.53.0 while retaining Go 1.25.0. Invoke the upstream executable directly, resolve it through Bazel runfiles in tests, and use absolute Compose file paths.

Use portable COPY and RUN chmod instructions so service image builds work without Buildx. Validate builds, unit tests, Docker integration and end-to-end suites, local startup and a landed demo request, and repository formatting and generation checks.
@mnoah1
mnoah1 force-pushed the mnoah1/pin-docker-compose branch from fee529a to 0128cca Compare October 9, 2026 18:05
@mnoah1 mnoah1 changed the title Draft: pin Docker Compose for local stacks and tests chore(docker): supply docker compose via Bazel Oct 9, 2026
@mnoah1
mnoah1 marked this pull request as ready for review October 9, 2026 18:09
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 9, 2026 18:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants