refactor: export the config linter and image registry for reuse

[pjcdawkins]

Makes the config linter importable by other Go modules:

• internal/lint → pkg/lint
• internal/lint/registry → pkg/registry (image registry, also used outside linting)
• internal/lint/schema → internal/schema (only used by pkg/lint)

Test data and the gen.go generators move with their packages. Imports, the update-registry/update-schema Makefile targets and CLAUDE.md are updated.

The public API is kept small:

• pkg/lint: CheckContent, CheckDir, Result, Issue and ErrEmptyContent. The individual checks and the config model are unexported; external tests reach them through export_test.go. Result exposes its Errors/Warnings fields, HasErrors, HasWarnings and String, and no longer implements error. FindProjectRoot moves to the lint command.
• pkg/registry: Load (was Parsed), Parse, Registry, Image, VersionInfo and ChannelStable. Unused Docs types are removed.

Behavior change: CheckDir no longer takes vendor conventions. It looks for .upsun/*.yaml (Flex), else .platform/ or .platform.app.yaml (Fixed), as both first-party CLIs already did. A CLI configured with another project_config_dir is no longer supported by lint.

The public packages note that other projects import them and that they are not covered by semantic versioning: the module has no /v5 path, so importers use pseudo-versions.

🤖 Generated with Claude Code

[upsun-dispatch]

📋 PR Summary

Moves the config linter from internal/lint to pkg/lint and the image registry to pkg/registry so other Go modules can import them. The schema package moves to internal/schema. Both public APIs are kept small. Result's mutators (addError, addWarning, merge) are now unexported, and ErrorLines/WarningLines are removed. CheckDir now detects Flex vs Fixed configuration from fixed directory names (.upsun/, .platform/ or .platform.app.yaml) and no longer takes vendor conventions, so a CLI configured with a different project_config_dir can no longer use lint.

Changes

Layer / File(s)	Summary
Public lint API
pkg/lint/result.go	Unexports AddError, AddWarning and Merge and removes ErrorLines/WarningLines.
pkg/lint/linter.go	New entry point that exposes CheckContent and CheckDir.
pkg/lint/normalize.go	Detects Flex vs Fixed directories without vendor conventions and switches to the unexported result helpers.
Lint checks
pkg/lint/types.go	Switches to the unexported addError/addWarning helpers. The other check files (dependencies, fixed, names, relationships, routes, scripts, tasks, web, yaml) change the same way.
pkg/lint/export_test.go	Gives external tests access to the unexported checks.
Registry
pkg/registry/registry.go	Moved from internal/lint/registry. Parsed is renamed to Load.
pkg/registry/model.go	Registry model with the unused Docs types removed.
Schema
internal/schema/gen.go	Moved from internal/lint/schema, with its generator path updated.
CLI
commands/lint.go	Now uses pkg/lint and contains FindProjectRoot, moved here from the lint package.
commands/lint_test.go	Tests build lint.Result values directly, since the add methods are no longer public.
Build and docs
Makefile	Points the update-registry and update-schema targets at the new paths.

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning

🔁 Incremental · 8 files reviewed

Verification

• checkDir gives the same detection order as before for first-party builds: Flex when .upsun has YAML files, else Fixed through the .platform/ dir or a root-level .platform.app.yaml, else an error.
• addStrayWarnings still warns about nested .upsun and .platform directories, the same pair of names the first-party vendor candidates used to produce.
• No code in the repo uses the removed registry.Docs, Web, Hooks or Location types or the Image.Description field, and no code still calls lint.Vendor or vendorFromConfig.
• The "flex wins over fixed" case added to TestDetectStyle replaces what the deleted TestCheckDir_Vendors covered for the first-party Platform.sh scenario.

The existing pkg/lint tests were updated to call checkDir(dir), and TestDetectStyle gained a test for Flex winning over Fixed. These and commands/lint_test.go run in the make test-go and golangci-lint steps of .github/workflows/ci.yml. The vendor-specific detection tests were deleted, and no test covers how lint behaves under a non-first-party project_config_dir.

Review details

• Commits: 57a4ca5..9fc7db7
• Model: claude-opus-5-5

---

Review 5 of 10 for this pull request · View the full run