fix(ordinal): accept eighth instead of eight as an ordinal - #333
anasbekheit wants to merge 2 commits into
Conversation
|
@cakebaker I think this fix may improve test parity with GNU |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 97.48% 97.74% +0.25%
==========================================
Files 21 21
Lines 4258 4293 +35
Branches 136 136
==========================================
+ Hits 4151 4196 +45
+ Misses 106 96 -10
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Are there any concerns blocking the merge of this PR? |
Merging this PR will degrade performance by 3.19%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | parse_invalid_input |
59 µs | 61 µs | -3.19% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing anasbekheit:fix/ordinal-eighth (80047a4) with main (e25bf15)
The ordinal table had
"eight"instead of"eighth", soeighth mondaywas rejected whileeight mondaywas accepted. GNUdateacceptseighth.