[v8] Migrate callback data accessors to DataV2() - #263
Open
deepak1556 wants to merge 1 commit into
Open
deepak1556 wants to merge 1 commit into
deepak1556 wants to merge 1 commit into
Conversation
Author
|
Built and verified |
deepak1556
commented
Sep 16, 2026
deepak1556
marked this pull request as draft
September 16, 2026 11:01
Use explicit Value casts for callback data that is known to contain JavaScript values, and pass Data directly where supported. Refs: https://issues.chromium.org/issues/559925519
deepak1556
force-pushed
the
robo/function_data_return_type_node_migration
branch
from
September 17, 2026 17:49
2a5a437 to
3f6c9d6
Compare
deepak1556
marked this pull request as ready for review
September 17, 2026 17:52
Author
|
@gahaas could you take a look, thanks! |
gahaas
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use explicit Value casts for callback data that is known to contain JavaScript values, and pass Data directly where supported.
Refs: https://issues.chromium.org/issues/559925519