Skip to content

[v8] Migrate callback data accessors to DataV2() - #263

Open
deepak1556 wants to merge 1 commit into
v8:node-ci-2026-08-05from
deepak1556:robo/function_data_return_type_node_migration
Open

deepak1556 wants to merge 1 commit into
v8:node-ci-2026-08-05from
deepak1556:robo/function_data_return_type_node_migration

Conversation

@deepak1556

@deepak1556 deepak1556 commented Sep 16, 2026

Copy link
Copy Markdown

Use explicit Value casts for callback data that is known to contain JavaScript values, and pass Data directly where supported.

Refs: https://issues.chromium.org/issues/559925519

@deepak1556

Copy link
Copy Markdown
Author

Built and verified node-ci on this branch and ToT V8 with

icu_use_data_file = false
is_debug = false
symbol_level = 0
is_component_build = false
node_use_node_code_cache = true
treat_warnings_as_errors = false
v8_imminent_deprecation_warnings = true
node_enable_deprecated_declarations_warnings = true

Comment thread src/node_wasm_web_api.cc
@deepak1556
deepak1556 marked this pull request as draft September 16, 2026 11:01
Use explicit Value casts for callback data that is known to contain
JavaScript values, and pass Data directly where supported.

Refs: https://issues.chromium.org/issues/559925519
@deepak1556
deepak1556 force-pushed the robo/function_data_return_type_node_migration branch from 2a5a437 to 3f6c9d6 Compare September 17, 2026 17:49
@deepak1556
deepak1556 marked this pull request as ready for review September 17, 2026 17:52
@deepak1556

Copy link
Copy Markdown
Author

@gahaas could you take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants