Repository navigation
Remove Any from public APIs - #48
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61f24268b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ValidationError.QualityViolation( | ||
| constraint = "nonEmpty", | ||
| violatedValue = "data", | ||
| message = "Dataset is empty", | ||
| ), |
There was a problem hiding this comment.
When data is empty, this constructor omits severity, so QualityViolation defaults to ErrorSeverity.Warning. The replaced QualityConstraint.NotNull used error severity, and this method still returns an invalid result, so consumers that route or alert based on severity will now treat the failed validation as only a warning. Pass severity = ErrorSeverity.Error, as the other rejecting quality validations do.
Useful? React with 👍 / 👎.
61f2426 to
c4b5ef7
Compare
|
Fixed. |
c4b5ef7 to
eda8f56
Compare
1 participant
Replaces
Anyin public signatures with closed types (ContextValue,SqlValue) and removes four unsound casts. Breaking API change: error context is nowMap[String, ContextValue]and the deadFieldConstraint.Customcase is deleted.CI now fails on
AnyorasInstanceOfin production sources, with a per-file allowlist for the reflection boundaries.