Repository navigation
Depend on ctdc-core instead of a second copy of the contract engine - #50
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba7e581ad7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "core" => Core.all ++ Monitoring.prometheus ++ Testing.unit | ||
| case "core" => | ||
| Core.all ++ Monitoring.prometheus ++ Testing.unit ++ Seq( | ||
| "com.vitthalmirji" %% "ctdc-core" % Versions.ctdc, |
There was a problem hiding this comment.
On a clean machine, core cannot resolve this new 0.1.0-SNAPSHOT dependency: the Sonatype snapshot resolvers at build.sbt:41 are declared as a root-project resolvers setting rather than ThisBuild / resolvers, so they are not inherited by the separately defined core project, and the CI workflow only checks out FlowForge rather than publishing ctdc locally. Configure the snapshot repository for core/ThisBuild, or depend on a released artifact available from the default repository.
Useful? React with 👍 / 👎.
| // 3.3.6 and not 3.3.3: ctdc-core is built with 3.3.6 and an older compiler cannot read newer TASTy. | ||
| val scala3 = "3.3.6" |
There was a problem hiding this comment.
The version catalog now requires 3.3.6 specifically because the older compiler cannot read ctdc's TASTy, but .github/workflows/ci.yml still invokes ++3.3.3 in the Scala 3 formatting step and sets the core/testQuick matrix entry to 3.3.3. Those explicit overrides bypass this new default, so the Scala 3 CI job still compiles core and its 3.3.6-built dependency with the incompatible compiler.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Deletes FlowForge's copy of the compile-time contract engine and depends on the ctdc-core library instead, so there is one implementation to maintain.
The contracts package now aliases the library types, so every call site stays unchanged.