Repository navigation
Zig16 rebase - #62548
Closed
m696e wants to merge 9 commits into
Closed
Zig16 rebase#62548m696e wants to merge 9 commits into
m696e wants to merge 9 commits into
Conversation
rip yorhel
The ncdu fork builds with system ncursesw and zstd via translate_c. Without pkg-config enabled, the translator doesn't pass the correct -I include paths for cross-compilation (e.g. armv7l, aarch64), causing 'curses.h not found' errors. The fix enables use_pkg_config = .yes so that translate-c calls pkg-config to get --cflags, which gives the proper cross-sysroot include paths. xbps-src already sets PKG_CONFIG to the cross wrapper with the correct PKG_CONFIG_SYSROOT_DIR.
Contributor
|
The description seems AI-generated, and the cross runs clearly are still failing. |
Contributor
Author
|
@tranzystorekk It is - I did this before I knew about the policy. To what extent should I do this myself? Is a full review of the contribution + handwritten description enough? or do it from scratch? |
Contributor
|
In the case of Zig in particular, it isn't helpful to open PRs trying to "speed up" the packaging process, and having AI involved only serves to make their job harder for maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
This is a rebased and fixed version of PR #59955 (Zig 0.16 update, stalled 5+ months).
Changes:
upstream/masterCross-compile fix detail:
ncdu2's
build.zigpasses system library names (ncursesw,zstd) totranslate-cvialink_system_libs, but withoutuse_pkg_config = .yes. On cross builds, the C compiler receives-nostdlibincand only the libc file's include paths —/usr/include/curses.hin the sysroot is found, but.../ncursesw/curses.hsubdirectories aren't. Enabling pkg-config makes translate-c callpkg-config ncursesw --cflags --libs, which returns the correct cross-sysroot include paths via the cross pkg-config wrapper that xbps-src already sets up.Changeset (11 files, +152/-42):
river-classicpackage)