Repository navigation
Conversation
…after cd A script such as `cd ui && vpr hello` planned the nested `vp run` in process. When `ui` is a separate project that this workspace does not list, the package query fell back to the enclosing package, so the workspace root's `hello` ran instead of `ui`'s. After a `cd`, if the new directory belongs to a different workspace root (`find_workspace_root`), the nested run now spawns as written, so it discovers its own workspace as it does in a shell. Fixes voidzero-dev/vite-plus#3129 Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(plan): plan nested run commands outside the workspace as written after cd
Motivation
In a script like
cd ui && vpr hello, whereuiis a separate project that the workspace does not list,vp runplanned the nestedvprin process. The package query for the new directory fell back to the enclosing package, so the workspace root'shelloran instead ofui's. The same command in a subshell, or typed in a shell, ranui'shello.After a
cd, the planner now checks whether the new directory belongs to a different workspace root. If it does, the nestedvp runis spawned as written, so it discovers its own workspace as it does in a shell. Directories inside the workspace, including workspace packages and subfolders without apackage.json, are planned in process as before.The check uses
find_workspace_root, so with #859 it also covers a nested project under apnpm-workspace.yamlthat doesn't list it (vite-plus#3013).Fixes voidzero-dev/vite-plus#3129