Repository navigation
fix(deploy): read Cloudflare versions that have no bindings - #458
Merged
Brooooooklyn merged 3 commits intoOct 18, 2026
Merged
Conversation
`cf workers versions get` prints the API response unchanged, so the field is missing from Cloudflare's own response. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/version-without-bindings
branch
from
October 18, 2026 07:06
366c3ab to
db436cb
Compare
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db436cb92a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Only a missing `bindings` field means "no bindings". A `null` value is malformed and must not pass as proof that the version has no secrets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457.
cf workers versions getleaves outbindingsfor a version that has none. Theversions.viewoperation treated that as an unreadable version, so if the Worker's newest version had no bindings, every latervoid deploy --platform cloudflarestopped at "could not verify which Worker Version would supply inherited secrets".A missing
bindingsnow reads as an empty list. Abindingsvalue that isn't an array is still rejected.cf-version-runner.test.ts. The file passes (75 tests), as do lint andtypecheckforpackages/void.Maintainer follow-up
main.cf.cf workers versions getprints the API response unchanged, so the API itself leaves outbindings.bindingschecks:cf-version-api.ts) only runs when the live version has secrets, so itsbindingslist is always there.versions.view(cloudflare-operation-process.ts) reads platform Workers, which always have bindings. Left as is.🤖 Generated with Claude Code