Repository navigation
fix(handler): infer output type for defineHandler with middleware - #490
Merged
Brooooooklyn merged 3 commits intoOct 19, 2026
Merged
Brooooooklyn merged 3 commits into
Brooooooklyn merged 3 commits into
Conversation
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61f7401cb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`(c) => R | Response | Promise<R | Response>` binds R from one promise, so a non-async loader that can return one of two promises, such as `cond ? loadAuthor() : loadBook()`, was rejected. The middleware forms accepted it before this branch. Take `(c) => R` and apply Awaited and Exclude<Response> to the output only, as withValidator does, in every overload. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
@codex review |
The previous commit typed the handler as `(c) => R`, which broke the documented `defineHandler<Props>(async (c) => ...)`: R is the loader's data, not its return value (platform dashboard typecheck failed). Keep `(c) => R | Response | Promise<R | Response>` for every overload, as on main, and give each middleware form a second overload that infers from the handler's return type, for loaders like `cond ? loadA() : loadB()`. The single-handler overload is unchanged from main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489.
The middleware overloads of
defineHandlerreturnedTypedHandlerwithout type arguments, so__outputwasunknownandInferPropsbroke. They now returnTypedHandler<{}, Exclude<Awaited<R>, Response>>, like the single-handler overload. No runtime change.Added cases with one and three middlewares to
infer-props.typecheck.tsfrom #478.Checked:
pnpm check:sdk,define-handler.test.ts