Repository navigation
Conversation
Markdown pages are implicit islands, so a Markdown-only site under target: 'node', output: 'static' relies on the islands plugin for the client input that prerendering needs. No playground covers this combination, so a regression there would go unnoticed. Add a Markdown-only playground (node-static-md) and an integration test that builds it and asserts the pages are prerendered and stay zero-JS. Verified against current main: the test passes on existing code, and fails (UNRESOLVED_ENTRY) when the islands client input is withheld. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Markdown-only playground (
playground/node-static-md) and an integration test (node-static-md.test.ts) fortarget: 'node'andoutput: 'static'. The test verifies that the pages are prerendered and reference no client-side JavaScript.Why
Markdown pages are implicit islands. When all pages are Markdown, the islands plugin must contribute the
islands-clientbuild input so that the client build, whosecloseBundleprerenders the pages, has an entry point.Existing coverage doesn't exercise this exact combination:
markdown-blog/zero-js: include explicit island components and use the default Cloudflare target.node-static: uses the Node target, but its React pages are not islands.Without coverage for Markdown-only pages on the Node static target, a regression in this behavior could go unnoticed.
Verification
Verified against current
main:islands-clientinput causes the build to fail withUNRESOLVED_ENTRY, confirming that the test detects the regression it is intended to guard against.Test and fixture only; no source changes.
🤖 Generated with Claude Code