Skip to content

Change release process to make releases immutable - #9845

Open
robert3005 wants to merge 2 commits into
developfrom
rk/releases
Open

robert3005 wants to merge 2 commits into
developfrom
rk/releases

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Document that binaries have to be built manually when making a release to allow
us to make releases immutable. Instead of appending binaries to an existing
release on publish we append them to draft and only publish once they're
populated

@robert3005 robert3005 added the changelog/docs A docs change label Sep 11, 2026
@codspeed

codspeed Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.19%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 6 regressed benchmarks
✅ 2245 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decode_primitives[f32, (1000, 512)] 42 µs 64.1 µs -34.49%
❌ Simulation take_map[(0.1, 0.5)] 155.8 µs 191.3 µs -18.57%
❌ Simulation random_i16[0.95] 81.5 µs 99.7 µs -18.27%
❌ Simulation take_map[(0.1, 1.0)] 229.3 µs 269.4 µs -14.87%
❌ WallTime filtered_owned_i64_avx2[OneNullInEight] 22.3 µs 25.6 µs -12.83%
❌ WallTime mul_i32_nonnull_avx512 7.1 µs 7.9 µs -10.61%
⚡ Simulation random_i8[0.5] 96 µs 72.4 µs +32.61%
⚡ Simulation allocate_drop_bytes[0] 635.5 ns 527.2 ns +20.55%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/releases (15507e9) with develop (c6678f3)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Oct 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/docs A docs change stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant