Skip to content

Develop correctly runs tests even if duckdb job is skipped - #9898

Merged
robert3005 merged 1 commit into
developfrom
rk/developtests
Sep 16, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/developtests

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Skipping duckdb mirroring shouldn't skip running these tests

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 15, 2026
@robert3005
robert3005 requested a review from myrrc September 15, 2026 22:55
@codspeed

codspeed Bot commented Sep 15, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 1 regressed benchmark
✅ 2197 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime mul_u32_nonnull_avx512 5.5 µs 6.2 µs -11.25%
⚡ WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.7 µs +20.35%
⚡ WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.2 µs +13.73%
⚡ Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%
⚡ Simulation allocate_drop_bytes[0] 575.7 ns 521.6 ns +10.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/developtests (23c50df) with develop (5c8cac4)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit 9a6d34a into develop Sep 16, 2026
102 of 104 checks passed
@robert3005
robert3005 deleted the rk/developtests branch September 16, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants