Skip to content

ci: force frame pointers for Codspeed - #9907

Merged
myrrc merged 1 commit into
developfrom
myrrc/codspeed-mold
Sep 16, 2026
Merged

myrrc merged 1 commit into
developfrom
myrrc/codspeed-mold

Conversation

@myrrc

@myrrc myrrc commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

As RUSTFLAGS were overriding rustflags from config, Codspeed runs were built without mold and
frame pointers

@myrrc
myrrc added this pull request to stack #9908 September 16, 2026 12:47
@myrrc
myrrc requested a review from AdamGS September 16, 2026 12:47
@codspeed

codspeed Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.47%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 19 regressed benchmarks
✅ 2218 untouched benchmarks
⏩ 176 skipped benchmarks1
🗄️ 1 archived benchmark run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime dict_canonicalize_gt_u8_avx512[16000000] 6.8 ms 11.3 ms -40.2%
❌ Simulation direct 13.8 µs 20.6 µs -33.13%
❌ Simulation random_i16[0.8] 77.1 µs 96.6 µs -20.21%
❌ Simulation lazy_lock 27.8 µs 34.5 µs -19.6%
❌ Simulation cpu_kernel 16.3 µs 19.8 µs -17.45%
❌ Simulation cpu_kernel_unconditional 16.3 µs 19.8 µs -17.45%
❌ Simulation feature_detect_each_call_1 18.4 µs 21.9 µs -15.85%
❌ Simulation feature_detect_each_call_3 18.4 µs 21.9 µs -15.85%
❌ Simulation decode_bool[10000_2_all_true] 222.6 µs 251.8 µs -11.57%
❌ Simulation allocate_drop_arrow[0] 456.9 ns 516.4 ns -11.54%
❌ Simulation compress[(10000, 4096)] 215.8 µs 243.4 µs -11.32%
❌ Simulation decode_bool[10000_2_all_false] 223.4 µs 251.6 µs -11.21%
❌ Simulation decode_bool[10000_2_mostly_true] 230.2 µs 258.7 µs -11%
❌ Simulation decompress[u64, (4000, 4)] 137 µs 153.9 µs -10.97%
❌ Simulation decode_bool[10000_2_mostly_false] 230.9 µs 259.1 µs -10.9%
❌ Simulation compress[(10000, 1024)] 194.7 µs 218 µs -10.71%
❌ Simulation compress[(10000, 256)] 199.3 µs 222.7 µs -10.5%
❌ Simulation rank_indices[(0.05, 0.05, "self_sparse_rank_sparse")] 75.6 µs 84.2 µs -10.23%
❌ Simulation null_count_run_end[(32000, 4, 0.01)] 433.6 µs 482.7 µs -10.17%
⚡ Simulation random_i8[0.5] 94.2 µs 71 µs +32.75%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/codspeed-mold (5c7dcd9) with develop (9a6d34a)3

Open in CodSpeed

Footnotes

  1. 176 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 1 benchmark was run, but is now archived. If it was deleted in another branch, consider rebasing to remove it from the report. Instead if it was added back, click here to restore it. ↩

  3. No successful run was found on develop (e38405d) during the generation of this report, so 9a6d34a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@0ax1

0ax1 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

We're doing this already in the cargo config.

Base automatically changed from myrrc/codspeed-rebalance-shards to develop September 16, 2026 13:02
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/codspeed-mold branch from 83a1a4b to 5c7dcd9 Compare September 16, 2026 13:02
@0ax1

0ax1 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
[target.'cfg(target_family="unix")']
rustflags = [
    "-C", "force-frame-pointers=yes",
]

@myrrc

myrrc commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@0ax1 That's the case, RUSTFLAGS were overriding this setting so it wasn't propagated.

Comment thread .github/workflows/codspeed.yml
@myrrc
myrrc merged commit 61f51cc into develop Sep 16, 2026
103 checks passed
@myrrc
myrrc deleted the myrrc/codspeed-mold branch September 16, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants