Update opencode config filename - #635
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @x-n2o on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
@x-n2o is attempting to deploy a commit to the warpdotdev Team on Vercel. A member of the Team first needs to authorize it. |
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
|
|
Thanks again for the contribution here, @x-n2o! Since OpenCode supports both opencode.json and opencode.jsonc, would you be open to updating the docs to mention both rather than replacing one with the other? Something like opencode.json / opencode.jsonc would make it clear that either format is supported. If you’re up for making that change, happy to keep this open! |
Thanks @hongyi-chen — updated the PR to mention both opencode.jsonc and opencode.json, and direct users to their existing configuration file. For context, OpenCode began automatically creating a global opencode.jsonc when no global config exists in anomalyco/opencode#26992, merged May 12, resolving anomalyco/opencode#4208. That was the motivation for the original change: helping users find the file OpenCode creates for them. Both extensions remain supported. The existing snippet also works unchanged with either filename, since comments are optional in JSONC. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, scoped, and improves filename accuracy; only a minor wording suggestion remains.
Pull request overview
This PR updates the OpenCode notifications documentation to reflect that OpenCode supports a JSON-with-comments config filename (opencode.jsonc), so readers aren’t pointed only at opencode.json.
Changes:
- Updated the notification plugin setup instruction to reference
opencode.jsonc(and also mentionsopencode.json).
File summaries
| File | Description |
|---|---|
| src/content/docs/agents/cli-agents/opencode.mdx | Updates the OpenCode notification plugin setup text to include the JSONC config filename. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary
Updated the OpenCode configuration filename reference in the documentation from
opencode.jsontoopencode.jsoncto match support for JSON with comments.Related issues
Closes #636
Validation
Verified that the documentation file
src/content/docs/agents/cli-agents/opencode.mdxcorrectly reflects theopencode.jsoncfilename used by the plugin configuration.Screenshots
None
Follow-ups
None