fix(docs): follow-up fixes for agent-docs-review non-blocking gate

[warp-factories]

Summary

PR #688 (fix(docs): make Agent docs review the only gate) merged into main before an in-progress adversarial review's findings could be pushed to its branch (the branch was deleted on merge). This follow-up PR fixes the three unaddressed findings so the non-blocking independent-review gate works as intended.

Related issues

Follow-up to #688. Tracked by QUALITY-2048.

Changes

• publish_review_signal.py — _REVIEW_EVENTS now recognizes the request_changes (underscore) verdict spelling in addition to request changes, matching verify_review_signal.py's _BLOCKING_VERDICTS. Previously a valid signal spelled request_changes raised unsupported review verdict instead of posting the required non-blocking comment.
• review-docs-pr/SKILL.md — The documented manual review-publishing snippet now maps every verdict (Approve, Approve with nits, Request changes) to a non-blocking COMMENT review, instead of mapping Request changes to the merge-blocking REQUEST_CHANGES event. Updated the surrounding prose to match.
• ci.yml — The Test doc_quality_policy step now runs test_stale_review_requests.py, which previously existed but was never invoked in CI.

Validation

• Added test_request_changes_underscore_spelling_maps_to_non_blocking_comment to test_publish_review_signal.py, proving the request_changes spelling now publishes a COMMENT event instead of raising.
• Updated test_publishing_snippet.py's test_findings_and_verdict_are_still_rendered to expect event == "COMMENT" for a Request changes verdict (previously asserted REQUEST_CHANGES).
• Ran locally, all passing: test_publish_review_signal.py, test_stale_review_requests.py, test_agent_docs_review_workflow.py, test_verify_review_signal.py, test_policy.py, test_check_pr_contract.py, test_check_compression_contract.py, test_manifest.py, review-docs-pr/test_publishing_snippet.py.
• CI on this PR should now exercise test_stale_review_requests.py for the first time.

Follow-ups

None.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: warp-factory.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 9, 2026 5:47pm UTC

[warp-factories]

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

  

[warp-for-oss]

@warp-factories[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-for-oss]

Overview

This PR aligns the agent-docs review publishing path with non-blocking GitHub review events and adds coverage for the underscore request_changes signal spelling plus the stale-review test in CI.

Concerns

• .agents/skills/review-docs-pr/SKILL.md:209 now blurs the policy/workflow split: the GitHub review event is non-blocking, but Agent docs review still fails on critical/important findings, and engineering review requests are advisory.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz