Repository navigation
Conversation
jh0ker
added this pull request to stack #127
October 6, 2026 15:37
✅ Deploy Preview for serene-narwhal-9b7b1c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for peaceful-raindrop-cb2462 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jh0ker
force-pushed
the
fix/page-meta-urls
branch
2 times, most recently
from
October 6, 2026 16:20
13cbdb6 to
df22b3b
Compare
The page URLs in the HTML meta tags still used the Serverless-era branch mapping and code4maus.wt.wdr.cloud domains, so dev and staging builds pointed to hosts that no longer exist. The stage domains now live in cdk/lib/stage-domains.json, read by both the CDK config and the frontend build. The deploy workflows pass the stage to the build via STAGE. The Route53 and ACM lookups in scripts/env.js were only used by serverless.yml and are removed along with promise-timeout.
jh0ker
force-pushed
the
fix/page-meta-urls
branch
from
October 6, 2026 17:08
df22b3b to
f9173c2
Compare
jh0ker
marked this pull request as ready for review
October 7, 2026 11:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page URLs in the HTML meta tags (
og:url,url,identifier-URL,og:image) still came from the Serverless-era branch mapping inscripts/env.js. Develop builds pointed atstaging.code4maus.wt.wdr.cloudand staging builds atdev.code4maus.wt.wdr.cloud. Only production was correct.cdk/lib/stage-domains.json. The CDK config reads it (withresolveJsonModule), and so doesscripts/env.js._deploy.ymland_deploy-gated.ymlpassSTAGEto the frontend build. Builds without it (local builds, PR checks) use dev. Netlify previews still useDEPLOY_PRIME_URL. An unknownSTAGEfails the build.scripts/env.js: drops the Route53/ACM lookups, which onlyserverless.ymlused, andpromise-timeoutwith them.serverless.ymlitself is removed further up the stack.cdk/DEPLOYMENT.mdlisted the old staging domain in its stage table; it's corrected, and the doc now says where the domains are configured.Tested: CDK
tsc,jest, andcdk synthfor dev and staging (same domains as before). Production builds withSTAGE=devandSTAGE=stagingproduce the expected meta URLs.