Skip to content

Fix editor regressions - #128

Draft
jh0ker wants to merge 4 commits into
developfrom
fix/app-regressions
Draft

jh0ker wants to merge 4 commits into
developfrom
fix/app-regressions

Conversation

@jh0ker

@jh0ker jh0ker commented Oct 6, 2026 •

Copy link
Copy Markdown
Member
  • Stage dragging: dragging sprites on the stage works again. It broke in bc3c6a1.
  • Saving: saving an existing project updates it instead of always creating a new one. The project id was read from state.router.params, which doesn't exist since the switch to connected-react-router; it now comes from withRouter. A backend regression test for this is in Replace serverless-offline with a local backend server #125.
  • Navigation blocker: the unsaved-project blocker only triggers when there are unsaved changes. It's only active in production builds (NODE_ENV=production).
  • Back to menu: going back to the menu while a game is running no longer throws, because the pending targets update is cancelled on unmount.

@netlify

netlify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for serene-narwhal-9b7b1c ready!

Name Link
🔨 Latest commit 7d26b11
🔍 Latest deploy log https://app.netlify.com/projects/serene-narwhal-9b7b1c/deploys/6acd08cf4d1490abbc7e422e
😎 Deploy Preview https://deploy-preview-128--serene-narwhal-9b7b1c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for peaceful-raindrop-cb2462 ready!

Name Link
🔨 Latest commit 7d26b11
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-raindrop-cb2462/deploys/6acd08cf3a1b94f51fea11ce
😎 Deploy Preview https://deploy-preview-128--peaceful-raindrop-cb2462.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

this appears to have broken with commit bc3c6a1
broke after switching to `connected-react-router`
It would always trigger, even when the project was not unsaved.

Note: This feature is disabled if `NODE_ENV !== 'production'`
@jh0ker
jh0ker force-pushed the fix/app-regressions branch from 6fea484 to 7d26b11 Compare October 12, 2026 16:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant