Repository navigation
Fix media service-worker imports and support OpenRouter videos - #3154
Merged
Merged
Conversation
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Polling reliability, extension-test synchronization, CI coverage, and documentation need correction.
Review effort: Balanced
Findings: 4
Open (5)
What changed in this PR
Adds OpenRouter video generation and fixes MV3 media imports.
Changes:
- Supports video model discovery, polling, and downloads.
- Replaces dynamic legacy imports with static exports.
- Adds media unit, UI, and extension tests; bumps version to 39.1.3.
| File | Description |
|---|---|
test/generative-media.mjs |
Tests video generation and static exports. |
test/generative-media-ui.mjs |
Mocks image model discovery. |
test/generative-media-extension.mjs |
Adds MV3 integration coverage. |
src/firefox/src/ui/settings.js |
Updates displayed version. |
src/firefox/src/ui/locales/generative-media-copy.mjs |
Adds video-oriented copy. |
src/firefox/src/agent/generative-media.js |
Implements OpenRouter videos. |
src/firefox/src/agent/fal-media.js |
Uses static legacy exports. |
src/firefox/manifest.json |
Bumps extension version. |
src/firefox/ARCHITECTURE.md |
Updates documented version. |
src/chrome/src/ui/settings.js |
Updates displayed version. |
src/chrome/src/ui/locales/generative-media-copy.mjs |
Adds video-oriented copy. |
src/chrome/src/agent/generative-media.js |
Implements OpenRouter videos. |
src/chrome/src/agent/fal-media.js |
Fixes MV3 legacy exports. |
src/chrome/manifest.json |
Bumps extension version. |
src/chrome/ARCHITECTURE.md |
Updates documented version. |
package.json |
Adds extension test command and version. |
package-lock.json |
Synchronizes package version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "test:generative-media": "node --test test/generative-media.mjs", | ||
| "test:generative-media:ui": "node test/generative-media-ui.mjs" | ||
| "test:generative-media:ui": "node test/generative-media-ui.mjs", | ||
| "test:generative-media:extension": "node test/generative-media-extension.mjs" |
Comment on lines
+142
to
+144
| const statusRes = await request(jobUrl, { headers }); | ||
| const status = await jsonResponse(statusRes, 'OpenRouter video status'); | ||
| waitMs = pollDelay(statusRes, pollMs); |
Comment on lines
+142
to
+144
| const statusRes = await request(jobUrl, { headers }); | ||
| const status = await jsonResponse(statusRes, 'OpenRouter video status'); | ||
| waitMs = pollDelay(statusRes, pollMs); |
Comment on lines
+38
to
+45
| await page.locator('#btn-save-image-gen').click(); | ||
| await page.waitForFunction(model => document.querySelector('#test-image-gen').classList.contains('ok') | ||
| && document.querySelector('#image-gen-model').value === model, model); | ||
| await page.locator('#btn-test-image-gen').click(); | ||
| await page.waitForFunction(() => { | ||
| const result = document.querySelector('#test-image-gen'); | ||
| return result.classList.contains('ok') || result.classList.contains('fail'); | ||
| }); |
| 'st.imagegen.setup': 'Setup guide ↗', | ||
| 'st.imagegen.hint.fal': 'Enter your fal.ai key and model ID. Test Connection checks authentication without generating media.', | ||
| 'st.imagegen.hint.openrouter': 'Enter an OpenRouter key and an image generation model ID. Test Connection checks the key and image catalog without generating an image.', | ||
| 'st.imagegen.hint.openrouter': 'Enter an OpenRouter key and an image or video generation model ID. Test Connection checks the key and model catalog without generating media.', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.