Repository navigation
Hide unconfigured media generation tools and guidance - #3155
Merged
Merged
Conversation
Bumps [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) from 1.30.0 to 1.31.0. - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@1.30.0...1.31.0) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.31.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ver/modelcontextprotocol/sdk-1.31.0 build(deps): bump @modelcontextprotocol/sdk from 1.30.0 to 1.31.0 in /mcp-server
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Planner guidance incorrectly excludes supported Full-tier Dev-mode media generation.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Adds configuration-aware generative-media availability across Chrome and Firefox.
Changes:
- Hydrates and tracks valid media configuration.
- Hides unavailable tools and adjusts planner guidance dynamically.
- Adds availability tests and updates dependencies.
| File | Description |
|---|---|
src/chrome/src/background.js |
Hydrates and watches media settings. |
src/chrome/src/agent/agent.js |
Propagates media availability into prompts and tools. |
src/chrome/src/agent/tools.js |
Filters and conditionally documents media tools. |
src/chrome/src/agent/planner.js |
Adds configuration-aware planner guidance. |
src/chrome/src/agent/media-config.js |
Defines media availability messages. |
src/firefox/src/background.js |
Mirrors media-setting hydration and watching. |
src/firefox/src/agent/agent.js |
Mirrors availability propagation. |
src/firefox/src/agent/tools.js |
Mirrors tool filtering and guidance. |
src/firefox/src/agent/planner.js |
Mirrors dynamic planner guidance. |
src/firefox/src/agent/media-config.js |
Mirrors availability messages. |
test/generative-media-availability.mjs |
Tests configuration, hydration, prompts, and tools. |
test/run.js |
Updates integration assertions and tool counts. |
package.json |
Includes availability tests in the media suite. |
mcp-server/package-lock.json |
Updates the MCP SDK lock entry. |
Files not reviewed (1)
- mcp-server/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return `${PLANNER_INTENT_SYSTEM_PROMPT}${opts.scheduledResume === true ? PLANNER_RESUME_RULE : ''}\n- Requested wbLocale for localized display fields: ${normalizePlannerLocale(opts.locale)}.${researchRule}${workflowRouting ? `\n\n${workflowRouting}` : ''}`; | ||
| const mediaStatus = opts.imageGenConfigured !== true ? GENERATIVE_MEDIA_SETUP_NOTE | ||
| : (opts.tier || 'full') !== 'full' ? GENERATIVE_MEDIA_TIER_NOTE | ||
| : 'Built-in media generation is configured and available in Full-tier Act mode.'; |
| return `${PLANNER_INTENT_SYSTEM_PROMPT}${opts.scheduledResume === true ? PLANNER_RESUME_RULE : ''}\n- Requested wbLocale for localized display fields: ${normalizePlannerLocale(opts.locale)}.${researchRule}${workflowRouting ? `\n\n${workflowRouting}` : ''}`; | ||
| const mediaStatus = opts.imageGenConfigured !== true ? GENERATIVE_MEDIA_SETUP_NOTE | ||
| : (opts.tier || 'full') !== 'full' ? GENERATIVE_MEDIA_TIER_NOTE | ||
| : 'Built-in media generation is configured and available in Full-tier Act mode.'; |
| // Provider settings are user-authored. Model tool arguments never select a host or key. | ||
| export const IMAGE_GEN_MODEL_KEY = 'imageGenModel'; | ||
| export const GENERATIVE_MEDIA_SETUP_NOTE = 'Built-in media generation requires setup in Settings → Assistive Models → Generative Media.'; | ||
| export const GENERATIVE_MEDIA_TIER_NOTE = 'Built-in media generation requires Full-tier Act mode.'; |
| // Provider settings are user-authored. Model tool arguments never select a host or key. | ||
| export const IMAGE_GEN_MODEL_KEY = 'imageGenModel'; | ||
| export const GENERATIVE_MEDIA_SETUP_NOTE = 'Built-in media generation requires setup in Settings → Assistive Models → Generative Media.'; | ||
| export const GENERATIVE_MEDIA_TIER_NOTE = 'Built-in media generation requires Full-tier Act mode.'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.