Skip to content

fix: give a direct addValue its own action row - #383

Merged
vishnuv688 merged 1 commit into
mainfrom
fix/352-direct-addvalue-action-row
Sep 18, 2026
Merged

vishnuv688 merged 1 commit into
mainfrom
fix/352-direct-addvalue-action-row

Conversation

@vishnuv688

@vishnuv688 vishnuv688 commented Sep 18, 2026

Copy link
Copy Markdown
Member

What & why

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Polish (an improvement to an existing feature)
  • Breaking change (existing behavior changes for users)
  • Documentation
  • Internal (build, CI, dependencies, tooling)

Packages touched

  • shared (types and contracts)
  • core (framework-agnostic capture/reporting)
  • elements (published element/snapshot API — @wdio/elements)
  • service (WebdriverIO adapter)
  • nightwatch-devtools (Nightwatch adapter)
  • selenium-devtools (Selenium adapter)
  • selenium-devtools-py (Selenium Python adapter)
  • backend (server)
  • app (UI)
  • script (page-injected runtime)
  • trace (Trace mode)

Notes for reviewers

Screenshots / recordings

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or release-management issues identified.

Summary

This PR makes a direct WebdriverIO addValue invocation appear as its own element-fill action while preserving suppression of the nested addValue used internally by setValue.

  • Adds addValue to the shared runner-command action vocabulary.
  • Verifies direct and nested command-stack behavior in the WebdriverIO service.
  • Updates shared mapping tests and provides a service patch changeset.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Direct["Direct addValue"] --> Stack["Top-level command stack"]
  Nested["setValue → nested addValue"] --> Suppressed["Nested command suppressed"]
  Stack --> Map["ACTION_MAP: Element.fill"]
  Map --> Trace["Dedicated trace action row"]
  Suppressed --> SetValue["Single setValue action row"]
Loading

Reviews (1) · Last reviewed commit: "fix: give a direct addValue its own acti..."

@vishnuv688 vishnuv688 self-assigned this Sep 18, 2026
@vishnuv688 vishnuv688 linked an issue Sep 18, 2026 that may be closed by this pull request
@vishnuv688
vishnuv688 merged commit 565bb0b into main Sep 18, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A direct addValue call produces no action row

1 participant