Repository navigation
Fix certvfy and tls examples for wolfSSL master API changes - #642
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Certificate date validation is lost, and one owning session reference leaks in default builds.
2 open findings
What changed in this PR
Updates examples for wolfSSL master API and session ownership changes.
Changes:
- Replaces borrowed TLS sessions with reference-counted sessions.
- Manually verifies certificate issuer and signature.
- Adds session cleanup in the TLS performance client.
| File | Description |
|---|---|
certvfy/certvfy.c |
Adapts certificate verification to the new API. |
tls/client-tls13-resume.c |
Uses an owning session reference. |
tls/client-tls-perf.c |
Manages owning session references across connections. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
certvfy: wc_ParseCert() now takes a WOLFSSL_CERT_MANAGER*, so a Signer can no longer be passed as the CA. Check the issuer and verify the signature with wc_CheckCertSigPubKey() instead. tls: NO_SESSION_CACHE_REF is now the default, so a session from wolfSSL_get_session() is freed with its connection. Use wolfSSL_get1_session() in client-tls13-resume and client-tls-perf.
SparkiDev
force-pushed
the
example_fixes_1
branch
from
October 9, 2026 02:17
145e1e2 to
9392da1
Compare
SparkiDev
requested review from
wolfSSL-Fenrir-bot
and
a balanced review from Copilot
October 9, 2026 02:20
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #642
Scan targets checked: wolfssl-examples-src, wolfssl-examples-bugs
Coverage: 3 of 3 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
philljj
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
certvfy: wc_ParseCert() now takes a WOLFSSL_CERT_MANAGER*, so a Signer
can no longer be passed as the CA. Check the issuer and verify the
signature with wc_CheckCertSigPubKey() instead.
tls: NO_SESSION_CACHE_REF is now the default, so a session from
wolfSSL_get_session() is freed with its connection. Use
wolfSSL_get1_session() in client-tls13-resume and client-tls-perf.