Repository navigation
task: add theme styles and third-party blocks toggles to the demo apps - #788
Merged
Merged
Conversation
Theme styles were always applied when the site supported them, so the demo apps could not show the editor without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Block assets were always loaded when the site supported them, so the demo apps could not show the editor without third-party blocks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new toggles change FeatureConfigurationCard's signature, which the baseline keys its existing LongMethod and LongParameterList entries on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/788")Built from 8c3918a |
Returning from Browse reloads the site configuration, which reset both toggles to site support while keeping dependencies prepared under the user's choice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EditorService reuses cached editor settings and asset bundles regardless of these flags, so prepared dependencies can include them while off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A toggle changed mid-prepare cleared the dependencies, only for the running prepare to store ones built under the previous setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dcalhoun
marked this pull request as ready for review
October 14, 2026 16:13
Contributor
|
@dcalhoun The first finding sounds like it should be addressed.
|
Returning from Browse re-ran the load, which reset every setting on the screen while keeping the prepared dependencies. This replaces the earlier re-apply of the feature toggles, which only covered those two. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… change Prepare now uses the selected post type, so dependencies prepared for one type no longer matched after switching. The picker also locks while preparing so a running prepare can't store stale ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The nonisolated helper started its Task off the main actor, so the prepare lock engaged late and observed state was written from a background thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its setter clears the prepared dependencies, which the running prepare then overwrote with ones built for the previous post type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@nbradbury thanks. I addressed items 1, 2, 3, and 6; these were preexisting. Finding 4 is intentional, it presumes site support when there is no network connection; the negative is a hidden, failed request. Finding 5 appears to be personal Claude configuration on your machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add Demo app feature toggles for theme styles and third-party blocks.
Why?
Simplify testing the editor with and without these features.
How?
Testing Instructions
Note
Theme styles requires the site have the Gutenberg plugin, third-party blocks requires the Jetpack plugins.
Accessibility Testing Instructions
N/A, unnecessary for the demo app.
Screenshots or screencast
AI-generated details
Adds "Enable Theme Styles" and "Enable Third-Party Blocks" toggles to the iOS and Android demo apps' site configuration screens.
EditorServicereuses cached editor settings and asset bundles regardless of these flags, so a warm cache can still supply them while off. Left for a library follow-up..onAppear, so returning from Browse no longer resets the screen's settings.FeatureConfigurationCard's new signature.🤖 Generated with Claude Code