Repository navigation
Conversation
Collaborator
Generated by 🚫 Danger |
1 task
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches its stated behavior and has thorough coverage of updates, previews, formatting, validation, and failures.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a Fastlane action that generates and safely updates versioned release notes from GitHub PR data.
Changes:
- Adds release-note generation with preview, validation, newline preservation, and failure safety.
- Corrects the GitHub configuration path parameter.
- Adds comprehensive RSpec coverage and changelog entries.
| File | Description |
|---|---|
CHANGELOG.md |
Documents the feature and parameter fix. |
lib/.../generate_release_notes_file.rb |
Implements the new Fastlane action. |
lib/.../github_helper.rb |
Corrects the GitHub API parameter. |
lib/.../release_notes_helper.rb |
Adds version-section replacement and insertion. |
spec/generate_release_notes_file_spec.rb |
Tests generation behavior and failure cases. |
spec/get_prs_between_tags_spec.rb |
Updates expectations for the corrected parameter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
generate_release_notes_filefor existing release lanes, addressing AINFRA-3084.It writes the Markdown returned by
get_prs_between_tagsdirectly under a version heading inRELEASE-NOTES.txt, preserving other versions.This implementation supports label exclusions, category headings, and previews, and API errors leave the file untouched.
Also fixes the configuration-path parameter sent to GitHub.
Initial implementation on the app side: woocommerce/woocommerce-android#16630
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendations.specs/*_spec.rb) if applicable.bundle exec rspecto run the whole test suite and ensure all your tests pass.CHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider. Not applicable: no breaking changes.