Repository navigation
fix: fall back from nonfinite Retry-After values - #742
Merged
Merged
Conversation
Contributor
 [High impact] The PR appears safe to merge; no outstanding finding or new issue was identified. SummaryThe PR rejects nonfinite and non-integer Retry-After values, caps valid retry sleeps, and adds sync and async regression tests. The changes since the previous review tighten those tests to distinguish fallback from capped delays. Reviews (3) · Last reviewed commit: "test: pin fallback sleep range for malfo..." · Reviewed by Greptile |
Rejecting only NaN/inf left the same failure one header away: a finite but huge Retry-After (e.g. 99999999999, or an HTTP-date centuries out) still overflows time.sleep and leaves asyncio.sleep waiting forever. Parse delay-seconds as RFC 9110 1*DIGIT so exponent notation, NaN and Infinity are rejected as syntax, and cap the sleep at MAX_RETRY_AFTER (60s, matching workos-node). The cap lives in _calculate_retry_delay so RateLimitExceededError.retry_after still reports the raw server value. Tests move next to the existing Retry-After tests in tests/test_generated_client.py and gain direct parser assertions.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The bounded-sleep tests accepted any delay up to MAX_RETRY_AFTER for NaN/Infinity/1e309, so a regression that capped instead of falling back to backoff would have passed. Pair each value with the range the client must use: first backoff step for malformed input, the cap for huge finite values.
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A malformed Retry-After header such as
NaN,Infinity, or an overflowing numeric value currently reaches time.sleep/asyncio.sleep. This can replace the API error with a ValueError/OverflowError or leave an asynchronous retry waiting indefinitely.Treat nonfinite numeric values as invalid headers and use the existing exponential backoff, just as for other unparseable Retry-After values. Valid numeric values and HTTP dates retain their behavior.
Six sync/async response regressions fail before the fix and pass afterward. The complete suite passes: 2,887 tests. Ruff and git diff --check pass.
Documentation
No public API or documentation changes required.