Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe spam-comment deletion guide now distinguishes bash-compatible shell behavior from Windows Command Prompt behavior. It adds a PowerShell example that splits returned IDs and skips deletion when no IDs are present. ChangesSpam-comment deletion guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new PowerShell guidance handles multiple, single, and empty ID lists, while the Bash example remains available for compatible shells. No merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates the spam-comment deletion documentation with shell-specific examples, including safe PowerShell handling.
Changes:
- Clarifies Bash-compatible shell support.
- Adds PowerShell ID splitting and empty-result handling.
| File | Description |
|---|---|
guides/common-tasks.md |
Documents Bash and PowerShell deletion commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mon2000x111-sketch
left a comment
There was a problem hiding this comment.
Approved in CodeRabbit Change Stack
mon2000x111-sketch
left a comment
There was a problem hiding this comment.
Approved in CodeRabbit Change Stack
mon2000x111-sketch
left a comment
There was a problem hiding this comment.
Approved in CodeRabbit Change Stack
|
We should probably have a dedicated Windows page/section at some point |
The spam-comment deletion example currently tells Windows users to run the same
$(...)command in PowerShell. With multiple IDs on one output line, PowerShell passes a single argument such as"11 22"to WP-CLI instead of the two ID arguments"11"and"22".Add a PowerShell example that splits the ID list on whitespace and skips deletion when the list is empty. Keep the existing Bash example and identify the shells it supports.
Fixes #664.
Validation: executed the original and corrected examples in Windows PowerShell 5.1.26100.9549 and PowerShell 7.6.5 through WP-CLI 2.12.0 / PHP 8.4.26 on Windows 11. A non-destructive
before_wp_loadcommand fixture reports the arguments received. Checked two IDs, one ID, and no IDs. The fixture exercises real WP-CLI argument parsing without deleting database records.git diff --checkalso passes.AI assistance: OpenAI Codex helped reproduce the shell behavior and prepare this documentation change and its tests.
Summary by CodeRabbit