Repository navigation
(#765) Restore Hadoop ByteBuffer compression compatibility - #766
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #765.
Hadoop 3.5.0's
SnappyCompressorsets its output buffer limit to zero before callingSnappy.compress. The bounds check added in #739 usesremaining(), so it rejects that buffer even when its allocated capacity is sufficient and causes Snappy-compressed SequenceFile writes to fail.Validate
capacity() - position()againstmaxCompressedLength(input.remaining())before invoking JNI. This restores the existing output-buffer behavior while preserving the check against insufficient allocated space, including output offsets and slice boundaries. The decompression bounds check protecting against #728 remains unchanged. Update the Javadoc to make the compression output-buffer semantics explicit.Add five regression tests covering empty output limits, nonzero positions, slices, insufficient capacity after the output position, and undersized slices backed by larger allocations.
Validation:
./sbt -batch testFull: 144 passed, 1 ignored, 0 failures.SnappyCompressorreproduction: successful compression and roundtrip with the fix; the prior check produces the exact reported exception.The complete Spark suite has not been rerun with this change.