Repository navigation
Fixes #1331 - Document adding checklist templates via trigger, macro and scheduler - #1340
Merged
Merged
Conversation
…and scheduler Add a section to the checklist page which documents the new perform action, the "Has checklist" condition and the behavior on tickets which already have a checklist. Link the action from the trigger, macro and scheduler pages, and point the webhook example at the native action. Verified against zammad develop (1c50c06a36, 8908ea6813, not in any tag yet): - Action group "Checklists" with "Add checklist template": _ui_element/_application_action.coffee:67-69,84-85 - Offered by trigger, macro and scheduler jobs: models/trigger.coffee:10, models/macro.coffee:7, models/job.coffee:10 - Scheduler jobs offer it for the Ticket object only (_ui_element/object_perform_action.coffee:34-39 plus the group filter which drops groups outside their model_show list) - Template selection field: views/generic/ticket_perform_action/checklist.jst.eco:3 - Appends to an existing checklist, keeping its name and items: models/checklist.rb:135-157 - Limit of 100 items per checklist, checked before anything is written: models/checklist/item.rb:109-112, models/checklist.rb:159-164 - "Has checklist" condition for triggers and scheduler jobs: _ui_element/_application_selector.coffee:185-189, _ui_element/object_selector.coffee:213-217, lib/selector/sql.rb:343-348 (EXISTS on checklist_items, so an empty checklist matches no). Gated on executionTime, which only trigger.coffee:9 and job.coffee:9 set, so it is not offered in overviews. Its operator list holds a single entry, so the selector hides the operator picker (toggleOperatorPicker, _ui_element/_application_selector.coffee:455-457, 505) and the table row documents no operator with yes/no as the only values (tests/qunit/form_object_selector.js:439-470). - Skip reasons: models/ticket/perform_changes/action/checklist_add_from_template.rb:10-20,30
ArtifactsProduced during runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a section to the checklist page which documents the new perform action, the "Has checklist" condition and the behavior on tickets which already have a checklist. Link the action from the trigger, macro and scheduler pages, and point the webhook example at the native action.