Repository navigation
style: fix pyink formatting on main (4 files) - #493
Merged
Merged
Conversation
… check CPUTests.yml runs 'pyink src/maxdiffusion --check' with pyink==23.10.0; on main aot_cache.py, tests/aot_cache_test.py, pipelines/wan/wan_pipeline.py and tests/wan/svg_attention_test.py fail it. Formatting only, no code changes.
There was a problem hiding this comment.
Code Review
This pull request consists entirely of code formatting improvements across several files, including aot_cache.py, wan_pipeline.py, and their corresponding test files. Specifically, multi-line statements and function calls have been simplified and flattened into single lines to improve readability. There are no functional changes to the codebase, and no review comments were provided, so I have no additional feedback to offer.
prishajain1
approved these changes
Sep 28, 2026
mbohlool
reviewed
Sep 29, 2026
mbohlool
left a comment
Collaborator
There was a problem hiding this comment.
only formatting issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main currently fails the CI
pyinkcheck (pyink==23.10.0, as pinned in.github/workflows/CPUTests.yml) on 4 files:src/maxdiffusion/aot_cache.pysrc/maxdiffusion/tests/aot_cache_test.pysrc/maxdiffusion/pipelines/wan/wan_pipeline.pysrc/maxdiffusion/tests/wan/svg_attention_test.pyThis makes CPU CI red on any PR based on main that doesn't touch those files (e.g. #477, #478). This PR runs pyink on exactly those files. Formatting only; no code changes.
Check:
pyink src/maxdiffusion end_to_end --check --pyink-indentation=2 --line-length=125→ 349 files unchanged.